From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD6C2E7719E for ; Mon, 13 Jan 2025 10:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ss0nS1GELbjiFby5ck0pE287JLIshiXmeo3+KQRZCwg=; b=GwxVBn3AviY/LGoS1S15gfgYGj uaE1DwQeTG+eCT6K+5Qn/NuFeKkQW6Pz/pihWqsF+kDC+B6gYz3VtwsG2xym2VIQX4Rk+tb3ihCDg vJCnMYVxjROtVQomJuNy8wmKRTzwBeFHi5kTxLOeGMJfvmkL+OetuFJniKDUK0bi5EyWQafe+BBh7 dQkt9b3rJq8FtmOrCKsbrgWV/yDp1Zh/AVMfJ8W0IiBuApQii3hfEt8f1YVZ5Rkyvk2/zJIm+a0aP Ej/0F3Q9IS7f9dfop1n4K/+2hmIpl1A9ucJ9mvUuyAMBVucJZxIL6FJSYh87dD7IStxAZTcF2f7YF /imOAOUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXHnG-00000004o3c-121G; Mon, 13 Jan 2025 10:35:38 +0000 Received: from smtp-out2.suse.de ([195.135.223.131]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tXHnC-00000004o23-3Ku6 for linux-nvme@lists.infradead.org; Mon, 13 Jan 2025 10:35:36 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5ABD41F37C; Mon, 13 Jan 2025 10:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736764533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ss0nS1GELbjiFby5ck0pE287JLIshiXmeo3+KQRZCwg=; b=E5gMW925mTJ+7mOiMKXQxl+g0girOeNAgIVR479FUZf2/qX31mIfI4yGo0mSFM0ZIjw8DN rhT7KFrziSFCyHfCC5Izz9nWDvQTEgMtgnsIEDlTmQrVo1I3bA49nI+3IiZMfdVxeUFeq7 A7J1wbVvVYzV4lUJ4tvHMHPbnEz9VQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736764533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ss0nS1GELbjiFby5ck0pE287JLIshiXmeo3+KQRZCwg=; b=H7Tm+oZfWJl/OQRIhoRNAIeogugLylUweJ/wV8mbKc9AJ4i3FJgxEKbQJ5NNvbElyiE+/O nyn4jkWCoWL2GtBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736764533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ss0nS1GELbjiFby5ck0pE287JLIshiXmeo3+KQRZCwg=; b=E5gMW925mTJ+7mOiMKXQxl+g0girOeNAgIVR479FUZf2/qX31mIfI4yGo0mSFM0ZIjw8DN rhT7KFrziSFCyHfCC5Izz9nWDvQTEgMtgnsIEDlTmQrVo1I3bA49nI+3IiZMfdVxeUFeq7 A7J1wbVvVYzV4lUJ4tvHMHPbnEz9VQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736764533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ss0nS1GELbjiFby5ck0pE287JLIshiXmeo3+KQRZCwg=; b=H7Tm+oZfWJl/OQRIhoRNAIeogugLylUweJ/wV8mbKc9AJ4i3FJgxEKbQJ5NNvbElyiE+/O nyn4jkWCoWL2GtBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 22D9613876; Mon, 13 Jan 2025 10:35:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qi0SCHXshGdzbAAAD6G6ig (envelope-from ); Mon, 13 Jan 2025 10:35:33 +0000 Message-ID: <416d25b1-bb0c-4563-bed7-158995259d75@suse.de> Date: Mon, 13 Jan 2025 11:35:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv7 RFC 3/3] nvme-multipath: Add visibility for queue-depth io-policy To: Nilay Shroff , linux-nvme@lists.infradead.org Cc: kbusch@kernel.org, sagi@grimberg.me, hch@lst.de, dwagner@suse.de, chaitanyak@nvidia.com, axboe@fb.com, gjoyce@linux.ibm.com References: <20250112124154.60690-1-nilay@linux.ibm.com> <20250112124154.60690-4-nilay@linux.ibm.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250112124154.60690-4-nilay@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250113_023534_976403_CF2E1281 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/12/25 13:41, Nilay Shroff wrote: > This patch helps add nvme native multipath visibility for queue-depth > io-policy. It adds a new attribute file named "queue_depth" under > namespace device path node which would print the number of active/ > in-flight I/O requests currently queued for the given path. > > For instance, if we have a shared namespace accessible from two different > controllers/paths then accessing head block node of the shared namespace > would show the following output: > > $ ls -l /sys/block/nvme1n1/multipath/ > nvme1c1n1 -> ../../../../../pci052e:78/052e:78:00.0/nvme/nvme1/nvme1c1n1 > nvme1c3n1 -> ../../../../../pci058e:78/058e:78:00.0/nvme/nvme3/nvme1c3n1 > > In the above example, nvme1n1 is head gendisk node created for a shared > namespace and the namespace is accessible from nvme1c1n1 and nvme1c3n1 > paths. For queue-depth io-policy we can then refer the "queue_depth" > attribute file created under each namespace path: > > $ cat /sys/block/nvme1n1/multipath/nvme1c1n1/queue_depth > 518 > > $cat /sys/block/nvme1n1/multipath/nvme1c3n1/queue_depth > 504 > >>>From the above output, we can infer that I/O workload targeted at nvme1n1 > uses two paths nvme1c1n1 and nvme1c3n1 and the current queue depth of each > path is 518 and 504 respectively. Reading "queue_depth" file when > configured io-policy is anything but queue-depth would show no output. > > Reviewed-by: Sagi Grimberg > Signed-off-by: Nilay Shroff > --- > drivers/nvme/host/multipath.c | 12 ++++++++++++ > drivers/nvme/host/nvme.h | 1 + > drivers/nvme/host/sysfs.c | 3 ++- > 3 files changed, 15 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich