From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FF34FA3741 for ; Tue, 25 Oct 2022 15:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x0Yzo3aybKV00mvxm0n+9+v1NGi8dTPJwFPa0omZxuE=; b=rFuOK6u45w6jvf RT8Ca4bHekMKFjd5hAALTh9lo1bBLdY4DrJp9UTryH24pabs+XQIRac8VSH+5XCpgT3Tj1J2MfI9t X0khFRwuL0IPOuaoL+SmMC717JqlUqZuPqzRPeGkPxP+5EZP2iGHPYsUD6o2vaMAu/5MKtsSrBQ+b 5FiDuCG48KrpijkmOWsyvjD7J3FetwQtn0rLVuKj8LVjf64ZvgdiYNk1wc6O19dZbcIzqtGRP3pvL TGysL2lEiTruQR66/jxdoCx5z7BesLzw1O13wZZ+YJc7Zh08dRajRIZO1loPODtICFDKnCENCdf6U jq+SYQFS+rQCagLzP+Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onLxj-0068BV-Gc; Tue, 25 Oct 2022 15:35:31 +0000 Received: from ale.deltatee.com ([204.191.154.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onLxg-00689q-TK for linux-nvme@lists.infradead.org; Tue, 25 Oct 2022 15:35:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=x0Yzo3aybKV00mvxm0n+9+v1NGi8dTPJwFPa0omZxuE=; b=TECqBrsdO3eJvM/HwoglBPPjsi dzMGqk2j2XncTUg3/bTvE9onc3miFg+MAkyNsga8bElyzRLnAvjYeSkIv+weqKScShndHJOo1rNGx /MSeBNPOBQzoaEF+lwDkJV1MvB/MZY+2ONVduaX1mcgFn7/A3C1VwH/FXVkppjmzXuQQpe3Y2xW/O KZenWN8CDqmV5JSRsm/v2dvyE5pkksWI9GfcoYs6ecrr/g1iXHiMwXwtDSS3CaUu8/T+5oC9vKi3w +etNolO1BjumECdDkTpeWXLoKwzZizi4zMD4uP8rOT1DO6H+twuEbalWwlcabsXQ8ZvEWd7UI0SYP CboL3j9w==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1onLxd-00H0QY-Ic; Tue, 25 Oct 2022 09:35:26 -0600 Message-ID: <41e621bb-e836-4a86-e6db-0beed19f5ddc@deltatee.com> Date: Tue, 25 Oct 2022 09:35:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-CA To: Chaitanya Kulkarni , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-mm@kvack.org" Cc: Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates References: <20221021174116.7200-1-logang@deltatee.com> <20221021174116.7200-4-logang@deltatee.com> <929ac68b-cf07-8df6-e589-49b0576a50c5@nvidia.com> From: Logan Gunthorpe In-Reply-To: <929ac68b-cf07-8df6-e589-49b0576a50c5@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: chaitanyak@nvidia.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, gregkh@linuxfoundation.org, dan.j.williams@intel.com, jgg@ziepe.ca, christian.koenig@amd.com, jhubbard@nvidia.com, ddutile@redhat.com, willy@infradead.org, daniel.vetter@ffwll.ch, dave.b.minturn@intel.com, jason@jlekstrand.net, dave.hansen@linux.intel.com, jianxin.xiong@intel.com, helgaas@kernel.org, ira.weiny@intel.com, robin.murphy@arm.com, martin.oliveira@eideticom.com, ckulkarnilinux@gmail.com, rcampbell@nvidia.com, sbates@raithlin.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v11 3/9] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_083529_073481_AE6EFF71 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2022-10-24 19:14, Chaitanya Kulkarni wrote: > On 10/21/22 10:41, Logan Gunthorpe wrote: >> Add iov_iter_get_pages_flags() and iov_iter_get_pages_alloc_flags() >> which take a flags argument that is passed to get_user_pages_fast(). >> >> This is so that FOLL_PCI_P2PDMA can be passed when appropriate. >> >> Signed-off-by: Logan Gunthorpe >> Reviewed-by: Christoph Hellwig >> --- >> include/linux/uio.h | 6 ++++++ >> lib/iov_iter.c | 32 ++++++++++++++++++++++++-------- >> 2 files changed, 30 insertions(+), 8 deletions(-) >> >> diff --git a/include/linux/uio.h b/include/linux/uio.h >> index 2e3134b14ffd..9ede533ce64c 100644 >> --- a/include/linux/uio.h >> +++ b/include/linux/uio.h >> @@ -247,8 +247,14 @@ void iov_iter_pipe(struct iov_iter *i, unsigned int direction, struct pipe_inode >> void iov_iter_discard(struct iov_iter *i, unsigned int direction, size_t count); >> void iov_iter_xarray(struct iov_iter *i, unsigned int direction, struct xarray *xarray, >> loff_t start, size_t count); >> +ssize_t iov_iter_get_pages(struct iov_iter *i, struct page **pages, >> + size_t maxsize, unsigned maxpages, size_t *start, >> + unsigned gup_flags); >> ssize_t iov_iter_get_pages2(struct iov_iter *i, struct page **pages, >> size_t maxsize, unsigned maxpages, size_t *start); >> +ssize_t iov_iter_get_pages_alloc(struct iov_iter *i, >> + struct page ***pages, size_t maxsize, size_t *start, >> + unsigned gup_flags); >> ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i, struct page ***pages, >> size_t maxsize, size_t *start); >> int iov_iter_npages(const struct iov_iter *i, int maxpages); >> diff --git a/lib/iov_iter.c b/lib/iov_iter.c >> index c3ca28ca68a6..53efad017f3c 100644 >> --- a/lib/iov_iter.c >> +++ b/lib/iov_iter.c >> @@ -1430,7 +1430,8 @@ static struct page *first_bvec_segment(const struct iov_iter *i, >> >> static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i, >> struct page ***pages, size_t maxsize, >> - unsigned int maxpages, size_t *start) >> + unsigned int maxpages, size_t *start, >> + unsigned int gup_flags) >> { >> unsigned int n; >> >> @@ -1442,7 +1443,6 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i, >> maxsize = MAX_RW_COUNT; >> >> if (likely(user_backed_iter(i))) { >> - unsigned int gup_flags = 0; >> unsigned long addr; >> int res; >> >> @@ -1492,33 +1492,49 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i, >> return -EFAULT; >> } >> >> -ssize_t iov_iter_get_pages2(struct iov_iter *i, >> +ssize_t iov_iter_get_pages(struct iov_iter *i, >> struct page **pages, size_t maxsize, unsigned maxpages, >> - size_t *start) >> + size_t *start, unsigned gup_flags) >> { >> if (!maxpages) >> return 0; >> BUG_ON(!pages); >> >> - return __iov_iter_get_pages_alloc(i, &pages, maxsize, maxpages, start); >> + return __iov_iter_get_pages_alloc(i, &pages, maxsize, maxpages, >> + start, gup_flags); >> +} >> +EXPORT_SYMBOL_GPL(iov_iter_get_pages); >> + >> +ssize_t iov_iter_get_pages2(struct iov_iter *i, struct page **pages, >> + size_t maxsize, unsigned maxpages, size_t *start) >> +{ >> + return iov_iter_get_pages(i, pages, maxsize, maxpages, start, 0); >> } >> EXPORT_SYMBOL(iov_iter_get_pages2); >> >> -ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i, >> +ssize_t iov_iter_get_pages_alloc(struct iov_iter *i, >> struct page ***pages, size_t maxsize, >> - size_t *start) >> + size_t *start, unsigned gup_flags) >> { >> ssize_t len; >> >> *pages = NULL; >> >> - len = __iov_iter_get_pages_alloc(i, pages, maxsize, ~0U, start); >> + len = __iov_iter_get_pages_alloc(i, pages, maxsize, ~0U, start, >> + gup_flags); >> if (len <= 0) { >> kvfree(*pages); >> *pages = NULL; >> } >> return len; >> } >> +EXPORT_SYMBOL_GPL(iov_iter_get_pages_alloc); >> + >> +ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i, >> + struct page ***pages, size_t maxsize, size_t *start) >> +{ >> + return iov_iter_get_pages_alloc(i, pages, maxsize, start, 0); >> +} >> EXPORT_SYMBOL(iov_iter_get_pages_alloc2); > Just one minor question why not make following functions > EXPORT_SYMBOL_GPL() ? > > 1. iov_iter_get_pages2() > 2. iov_iter_get_pages_alloc2() They previously were not GPL, so I didn't think that should be changed in this patch. Thanks for the review! Logan