From: Hannes Reinecke <hare@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>, Yi Zhang <yi.zhang@redhat.com>
Cc: linux-nvme@lists.infradead.org, skt-results-master@redhat.com,
Bruno Goncalves <bgoncalv@redhat.com>
Subject: Re: [bug report] blktests nvme/022 lead kernel WARNING and NULL pointer
Date: Sun, 9 May 2021 10:44:13 +0200 [thread overview]
Message-ID: <423b7c5e-deb7-3547-6ca4-8f4476e9eb03@suse.de> (raw)
In-Reply-To: <201a97a9-e42f-8d8e-3cc7-e5cf8ba816c2@grimberg.me>
On 5/7/21 9:50 PM, Sagi Grimberg wrote:
>
>>> Hi Sagi
>>>
>>> Bisect shows bellow commits was the first bad commit.
>>>
>>> commit a70b81bd4d9d2d6c05cfe6ef2a10bccc2e04357a (refs/bisect/bad)
>>> Author: Hannes Reinecke <hare@suse.de>
>>> Date: Fri Apr 16 13:46:20 2021 +0200
>>>
>>> nvme: sanitize KATO setting
>>>
>>
>> Hi Sagi
>> This issue has been consistently reproduced with blktests on recent
>> linux-block/for-next, do you have a chance to check it?
>
> I had not, Hannes can you have a look?
>
Can you check if this patch helps?
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 74b3b150e1a5..a48d8219cf90 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -458,6 +458,9 @@ static void nvme_loop_reset_ctrl_work(struct
work_struct *work)
container_of(work, struct nvme_loop_ctrl, ctrl.reset_work);
int ret;
+ /* reset_work might run concurrently to delete_work */
+ if (ctrl->state == NVME_CTRL_DELETING)
+ return;
nvme_stop_ctrl(&ctrl->ctrl);
nvme_loop_shutdown_ctrl(ctrl);
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-09 8:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 16:40 [bug report] blktests nvme/022 lead kernel WARNING and NULL pointer Yi Zhang
2021-05-01 0:55 ` Sagi Grimberg
2021-05-01 9:58 ` Yi Zhang
2021-05-07 8:35 ` Yi Zhang
2021-05-07 19:50 ` Sagi Grimberg
2021-05-09 8:44 ` Hannes Reinecke [this message]
2021-05-12 0:32 ` Yi Zhang
2021-05-19 0:36 ` Yi Zhang
2021-05-20 6:19 ` Hannes Reinecke
2021-05-21 0:38 ` Yi Zhang
2021-05-21 18:19 ` Sagi Grimberg
2021-05-22 0:12 ` Yi Zhang
2021-05-22 14:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423b7c5e-deb7-3547-6ca4-8f4476e9eb03@suse.de \
--to=hare@suse.de \
--cc=bgoncalv@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=skt-results-master@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox