From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v8 0/1] Implement the NVMe reservation feature
Date: Tue, 12 Mar 2024 00:50:32 +0000 [thread overview]
Message-ID: <43565275-d71b-4c51-9a5c-b528e6387614@nvidia.com> (raw)
In-Reply-To: <105d14ec-b4db-44e7-b98a-135787c17b10@grimberg.me>
On 3/7/24 00:18, Sagi Grimberg wrote:
>
>
> On 05/03/2024 4:32, Guixin Liu wrote:
>> Hi Sagi,
>>
>> Friendly ping. If you have no further concerns with this patch, I
>> would be very grateful
>>
>> if you could provide a "Reviewed-by" tag. Such an endorsement would
>> be immensely encouraging
>>
>> for my work in this area.
>>
>> Thank you very much for reviewing this patch and for the valuable
>> suggestions you have provided.
>
> Sure, I do think we need at least one more reviewer.
>
> Plus, I don't think a target-side reservations maintainers entry is
> justified here, it is a part of nvmet.
> So please drop it from your next submission.
Can you please send a next version with Sagi's comments ? also can you
please send blktests if you have any so I can run some tests once I finish
the review on next version ?
-ck
next prev parent reply other threads:[~2024-03-12 0:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 3:12 [PATCH v8 0/1] Implement the NVMe reservation feature Guixin Liu
2024-02-29 3:12 ` [PATCH v8 1/1] nvmet: support " Guixin Liu
2024-09-17 8:43 ` Dmitry Bogdanov
2024-09-18 8:26 ` Guixin Liu
2024-09-18 13:41 ` Dmitry Bogdanov
2024-09-19 11:42 ` Guixin Liu
2024-03-05 2:32 ` [PATCH v8 0/1] Implement the NVMe " Guixin Liu
2024-03-07 8:18 ` Sagi Grimberg
2024-03-12 0:50 ` Chaitanya Kulkarni [this message]
2024-03-12 3:39 ` Guixin Liu
2024-07-05 16:45 ` hch
2024-09-18 8:30 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43565275-d71b-4c51-9a5c-b528e6387614@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox