From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "hch@lst.de" <hch@lst.de>
Cc: Alan Adamson <alan.adamson@oracle.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [RFC v4 1/1] nvme: add passthrough admin error logging opt-in
Date: Sun, 9 Apr 2023 21:32:10 +0000 [thread overview]
Message-ID: <4508951d-9bb9-a25a-c6f1-e5ee91e6ef79@nvidia.com> (raw)
In-Reply-To: <20230407074818.GA9335@lst.de>
On 4/7/23 00:48, hch@lst.de wrote:
> On Fri, Apr 07, 2023 at 04:45:59AM +0000, Chaitanya Kulkarni wrote:
>> + const char *device_name = dev_name(nr->ctrl->device);
>>
>> + if (ns)
>> + device_name = ns->disk ? ns->disk->disk_name : "?";
> I don't see how ns->disk could ever be NULL here. So this could
> be a simple
>
> ns ? ns->disk->disk->name : dev_name(nr->ctrl->device)
>
> in the parameter list. We'd still need to also call
> nvme_get_admin_opcode_str to get the actual command name as well.
>
sent out a tested V5 with all the fixes I mentioned and your
suggestion...
-ck
next prev parent reply other threads:[~2023-04-09 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 21:55 [RFC v4 0/1] nvme: add passthrough admin error logging opt-in Alan Adamson
2023-04-06 21:55 ` [RFC v4 1/1] " Alan Adamson
2023-04-07 4:45 ` Chaitanya Kulkarni
2023-04-07 7:48 ` hch
2023-04-07 17:48 ` Chaitanya Kulkarni
2023-04-09 21:32 ` Chaitanya Kulkarni [this message]
2023-04-07 4:46 ` [RFC v4 0/1] " Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4508951d-9bb9-a25a-c6f1-e5ee91e6ef79@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=alan.adamson@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox