Re: [RFC PATCH 2/4] nvme-tcp: add a diagnostic message when NIC queues are underutilized

[Nilay Shroff <nilay@linux.ibm.com>]

On 4/25/26 3:45 AM, Sagi Grimberg wrote:
> 
> 
> On 20/04/2026 14:49, Nilay Shroff wrote:
>> Some systems may configure fewer NIC queues than supported by the
>> hardware. When the number of NVMe-TCP I/O queues is limited by the
>> number of active NIC queues, this can result in suboptimal performance.
>>
>> Add a diagnostic message to warn when the configured NIC queue count
>> is lower than the maximum supported queue count, as reported by the
>> driver. This may help users identify configurations where increasing
>> the NIC queue count could improve performance.
>>
>> This change is informational only and does not modify NIC configuration.
> 
> I don't think that we want this at all. I don't think this is nvme-tcp place
> to print such a log message at all. Especially not every time it connects
> to a controller.
> 
> If you think you need to add this, create a userspace nvmf tool that
> tests/validates a host.

Okay we can drop this from kernel and may add it in userspace tool such
as nvme connect...

Thanks,
--Nilay