From: Wen Xiong <wenxiong@linux.ibm.com>
To: John Garry <john.g.garry@oracle.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org,
gjoyce@linux.ibm.com, wenxiong@us.ibm.com
Subject: Re: [PATCH] nvme: Add module reference counting for multipath nvme device
Date: Wed, 12 Aug 2026 09:32:17 -0500 [thread overview]
Message-ID: <47b2e26ba57947f21c70ba0c4bc8cc04@linux.ibm.com> (raw)
In-Reply-To: <0c8b8a88-8f0c-40cc-b6ba-59b12b8f555f@oracle.com>
On 2026-08-12 03:43, John Garry wrote:
> Can't the tester also just unbind the device from the driver, which
> does the same (as unloading the driver)?
>
> Example:
> echo 0000:00:04.0 > /sys/bus/pci/drivers/nvme/unbind
>
> For this PCI case, we call nvme_remove() -> nvme_remove_namespaces()
> -> nvme_ns_remove(), which removes the NS path and deletes the gendisk
> if the last path. Same effect, as I see.
>
Yes. Both rmmod nvme and unbind are test cases for the tester.
rmmod nvme should not be allowed when the module reference count is
non-zero. However, unbind is allowed even when the reference count is
non-zero; it should decrease the reference count.
next prev parent reply other threads:[~2026-08-12 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 23:50 [PATCH] nvme: Add module reference counting for multipath nvme device wenxiong
2026-08-11 13:18 ` John Garry
2026-08-11 18:54 ` Wen Xiong
2026-08-12 8:43 ` John Garry
2026-08-12 14:32 ` Wen Xiong [this message]
2026-08-11 19:12 ` Keith Busch
2026-08-11 20:33 ` Wen Xiong
2026-08-11 20:49 ` Keith Busch
2026-08-12 3:59 ` Wen Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b2e26ba57947f21c70ba0c4bc8cc04@linux.ibm.com \
--to=wenxiong@linux.ibm.com \
--cc=gjoyce@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox