From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-ioctl: move capable() admin check to the end
Date: Thu, 30 Nov 2023 16:09:54 -0700 [thread overview]
Message-ID: <48212850-89e7-42d4-bd9a-93d0c35bc38f@kernel.dk> (raw)
In-Reply-To: <20231130201919.2486553-1-kbusch@meta.com>
On 11/30/23 1:19 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> This can be an expensive call on some distros. Move it to the end after
> checking the cheaper ways to determine if the command is allowed.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2023-11-30 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 20:19 [PATCH] nvme-ioctl: move capable() admin check to the end Keith Busch
2023-11-30 23:09 ` Jens Axboe [this message]
2023-12-04 8:17 ` Sagi Grimberg
2023-12-04 8:30 ` Christoph Hellwig
2023-12-04 14:33 ` Keith Busch
2023-12-04 14:35 ` Christoph Hellwig
2023-12-04 15:42 ` Keith Busch
2023-12-04 15:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48212850-89e7-42d4-bd9a-93d0c35bc38f@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox