Re: [bug report]nvme0: Admin Cmd(0x6), I/O Error (sct 0x0 / sc 0x2) MORE DNR observed during blktests

[Jonathan Derrick <jonathan.derrick@linux.dev>]

On 4/4/2022 11:02 AM, Keith Busch wrote:
> On Mon, Apr 04, 2022 at 04:39:06PM +0000, Alan Adamson wrote:
>>
>> [   97.083215] nvme0: Admin Cmd(0x6), I/O Error (sct 0x0 / sc 0x2) MORE DNR
>>
>> An error from the device (status=2/Invalid Field) when an Identify (0x6) command was issued. Prior to the patch,
>> the nvme driver didn’t display the error.
>   
> And it's harmless. The driver is querying an optional identification and it's
> okay if the device doesn't support it, but the driver doesn't know if the
> device supports until it tries it.
I've had to field bug reports like this before, where it says error in 
dmesg but is actually harmless.

Maybe we could suppress the error and add a harmless print?
Eg, nvme0: blah blah command set not supported


>   
>>> On Apr 3, 2022, at 7:28 AM, Yi Zhang <yi.zhang@redhat.com> wrote:
>>>
>>> Hello
>>>
>>> I found this error log during blktests[1] with the latest
>>> linux-block/for-next, seems it was introduced after commit[2], is that
>>> expected?
>>>
>>> [1]
>>> [   96.931911] run blktests nvme/004 at 2022-04-02 20:53:16
>>> [   97.024693] loop: module loaded
>>> [   97.029319] loop0: detected capacity change from 0 to 2097152
>>> [   97.039641] nvmet: adding nsid 1 to subsystem blktests-subsystem-1
>>> [   97.068847] nvmet: creating nvm controller 1 for subsystem
>>> blktests-subsystem-1 for NQN
>>> nqn.2014-08.org.nvmexpress:uuid:4c4c4544-0035-4b10-8044-b9c04f463333.
>>> [   97.083215] nvme0: Admin Cmd(0x6), I/O Error (sct 0x0 / sc 0x2) MORE DNR
>>> [   97.090108] nvme nvme0: creating 32 I/O queues.
>>> [   97.098283] nvme nvme0: new ctrl: "blktests-subsystem-1"
>>> [   98.136900] nvme nvme0: Removing ctrl: NQN "blktests-subsystem-1"
>>>
>>> [2]
>>> commit bd83fe6f2cd2133beaac7c423fd36c3515048fc8
>>> Author: Alan Adamson <alan.adamson@oracle.com>
>>> Date:   Thu Feb 3 00:11:53 2022 -0800
>>>
>>>     nvme: add verbose error logging
>>>
>>> -- 
>>> Best Regards,
>>>   Yi Zhang
>>>
>>
>