From: jonathan.derrick@intel.com (Jon Derrick)
Subject: [PATCH] nvme: Add support for NVMe 1.3 Timestamp Feature
Date: Tue, 18 Jul 2017 15:12:55 -0600 [thread overview]
Message-ID: <4dea408c-c020-97aa-c6f6-4f10583ecf00@intel.com> (raw)
In-Reply-To: <59e271b0-00d8-d705-b56e-a93d7b21e393@grimberg.me>
On 07/13/2017 01:01 AM, Sagi Grimberg wrote:
>
>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>> index 5d5aa7f..82ce677 100644
>> --- a/drivers/nvme/host/pci.c
>> +++ b/drivers/nvme/host/pci.c
>> @@ -2156,6 +2156,10 @@ static void nvme_reset_work(struct work_struct *work)
>> if (result)
>> goto out;
>>
>> + if (dev->ctrl.vs >= NVME_VS(1, 3, 0) &&
>> + dev->ctrl.oncs & NVME_CTRL_ONCS_TIMESTAMP)
>> + nvme_set_timestamp(&dev->ctrl);
>> +
>
> Why after setting up the I/O queues?
>
No reason in particular; I just wanted it in the reset path.
For v2 I've moved it to the identify path.
next prev parent reply other threads:[~2017-07-18 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 22:11 [PATCH] nvme: Add support for NVMe 1.3 Timestamp Feature Jon Derrick
2017-07-12 23:24 ` Keith Busch
2017-07-13 7:01 ` Sagi Grimberg
2017-07-18 21:12 ` Jon Derrick [this message]
2017-07-13 7:35 ` Christoph Hellwig
2017-07-18 21:13 ` Jon Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dea408c-c020-97aa-c6f6-4f10583ecf00@intel.com \
--to=jonathan.derrick@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox