From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 1/2] nvme-multipath: add 'iopolicy' subsystem attribute
Date: Thu, 15 Nov 2018 09:35:55 -0800 [thread overview]
Message-ID: <4e31f5b2-077b-8ed6-7b9e-3ffcb4948d68@grimberg.me> (raw)
In-Reply-To: <20181115122927.40431-2-hare@suse.de>
> +static ssize_t nvme_subsys_iopolicy_store(struct device *dev,
> + struct device_attribute *attr, const char *buf, size_t count)
> +{
> + unsigned int iopolicy = NVME_IOPOLICY_UNKNOWN;
> +
> + if (!strncmp(buf, "none", 4))
> + iopolicy = NVME_IOPOLICY_NONE;
> + else if (!strncmp(buf, "numa", 4))
> + iopolicy = NVME_IOPOLICY_NUMA;
> +
> + if (iopolicy == NVME_IOPOLICY_UNKNOWN)
> + return -EINVAL;
Missed assignment to subsys->iopolicy?
next prev parent reply other threads:[~2018-11-15 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:29 [PATCH 0/2] nvme-multipath: round-robin I/O policy Hannes Reinecke
2018-11-15 12:29 ` [PATCH 1/2] nvme-multipath: add 'iopolicy' subsystem attribute Hannes Reinecke
2018-11-15 17:35 ` Sagi Grimberg [this message]
2018-11-16 8:07 ` Hannes Reinecke
2018-11-15 12:29 ` [PATCH 2/2] nvme-multipath: round-robin I/O policy Hannes Reinecke
2018-11-20 16:42 ` Christoph Hellwig
2018-11-20 20:30 ` Hannes Reinecke
2018-11-21 8:28 ` Christoph Hellwig
2018-11-21 11:24 ` Hannes Reinecke
[not found] ` <8a583536-151e-6f68-f4f9-98d8c4b853dd@broadcom.com>
2018-11-21 11:09 ` Hannes Reinecke
2018-11-22 13:52 ` Hannes Reinecke
2018-11-16 8:26 ` [PATCH 0/2] " Christoph Hellwig
2018-11-20 16:02 ` Hannes Reinecke
2018-11-20 16:19 ` Christoph Hellwig
2018-12-05 20:05 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e31f5b2-077b-8ed6-7b9e-3ffcb4948d68@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).