From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Yi Zhang <yi.zhang@redhat.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
linux-block <linux-block@vger.kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
Rachel Sibley <rasibley@redhat.com>,
CKI Project <cki-project@redhat.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: kernel null pointer at nvme_tcp_init_iter+0x7d/0xd0 [nvme_tcp]
Date: Wed, 10 Feb 2021 14:06:31 -0800 [thread overview]
Message-ID: <502e8d85-90cf-9533-0f83-364bee2fd34b@grimberg.me> (raw)
In-Reply-To: <BYAPR04MB49652279710E99EBB6F8AC67868D9@BYAPR04MB4965.namprd04.prod.outlook.com>
>> So it's nvme_admin_abort_cmd here
>>
>> [ 74.017450] run blktests nvme/012 at 2021-02-09 21:41:55
>> [ 74.111311] loop: module loaded
>> [ 74.125717] loop0: detected capacity change from 2097152 to 0
>> [ 74.141026] nvmet: adding nsid 1 to subsystem blktests-subsystem-1
>> [ 74.149395] nvmet_tcp: enabling port 0 (127.0.0.1:4420)
>> [ 74.158298] nvmet: creating controller 1 for subsystem
>> blktests-subsystem-1 for NQN
>> nqn.2014-08.org.nvmexpress:uuid:41131d88-02ca-4ccc-87b3-6ca3f28b13a4.
>> [ 74.158742] nvme nvme0: creating 48 I/O queues.
>> [ 74.163391] nvme nvme0: mapped 48/0/0 default/read/poll queues.
>> [ 74.184623] nvme nvme0: new ctrl: NQN "blktests-subsystem-1", addr
>> 127.0.0.1:4420
>> [ 75.235059] nvme_tcp: rq 38 opcode 8
>> [ 75.238653] blk_update_request: I/O error, dev nvme0c0n1, sector
>> 1048624 op 0x9:(WRITE_ZEROES) flags 0x2800800 phys_seg 0 prio class 0
>> [ 75.380179] XFS (nvme0n1): Mounting V5 Filesystem
>> [ 75.387457] XFS (nvme0n1): Ending clean mount
>> [ 75.388555] xfs filesystem being mounted at /mnt/blktests supports
>> timestamps until 2038 (0x7fffffff)
>> [ 91.035659] XFS (nvme0n1): Unmounting Filesystem
>> [ 91.043334] nvme nvme0: Removing ctrl: NQN "blktests-subsystem-1"
>
> But write-zeores is also data less command and should not fail.
And it has a bio, which means that nvme-tcp tries to init an iter
for it when it shouldn't. So the actual offending commit is:
cb9b870fba3e, which cleaned up how the iter is initialized but
introduced this issue.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-10 22:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cki.F3E139361A.EN5MUSJKK9@redhat.com>
[not found] ` <630237787.11660686.1612580898410.JavaMail.zimbra@redhat.com>
2021-02-07 4:50 ` kernel null pointer at nvme_tcp_init_iter[nvme_tcp] with blktests nvme-tcp/012 Yi Zhang
2021-02-07 5:25 ` Chaitanya Kulkarni
2021-02-08 6:48 ` Yi Zhang
2021-02-07 5:48 ` Chaitanya Kulkarni
2021-02-07 5:58 ` Chaitanya Kulkarni
2021-02-07 7:14 ` kernel null pointer at nvme_tcp_init_iter+0x7d/0xd0 [nvme_tcp] Chaitanya Kulkarni
2021-02-08 9:53 ` Sagi Grimberg
2021-02-08 9:46 ` Sagi Grimberg
2021-02-08 13:28 ` Yi Zhang
2021-02-08 17:54 ` Sagi Grimberg
2021-02-08 18:42 ` Sagi Grimberg
2021-02-09 4:21 ` Ming Lei
2021-02-09 7:21 ` Sagi Grimberg
2021-02-09 7:50 ` Ming Lei
2021-02-09 8:34 ` Chaitanya Kulkarni
2021-02-09 10:09 ` Sagi Grimberg
2021-02-09 10:07 ` Sagi Grimberg
2021-02-09 10:33 ` Ming Lei
2021-02-09 10:36 ` Sagi Grimberg
2021-02-09 10:25 ` Sagi Grimberg
2021-02-09 12:57 ` Yi Zhang
2021-02-09 18:01 ` Sagi Grimberg
2021-02-10 2:51 ` Yi Zhang
2021-02-10 3:38 ` Keith Busch
2021-02-10 5:03 ` Chaitanya Kulkarni
2021-02-10 22:06 ` Sagi Grimberg [this message]
2021-02-10 22:15 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502e8d85-90cf-9533-0f83-364bee2fd34b@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=cki-project@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=rasibley@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox