From: Heiner Kallweit <hkallweit1@gmail.com>
To: Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: linux-next: NVME using PCI legacy interrupts only
Date: Wed, 9 Jun 2021 20:43:57 +0200 [thread overview]
Message-ID: <52371274-20bc-a150-a3ed-ba3e1305ad3e@gmail.com> (raw)
I found that on linux-next from June 8th my nvme disk is using legacy
interrupts only. Some debugging lead me to irq_find_mapping() in
msi_domain_alloc() returning -EEXIST.
The nvme core first allocates a MSI-X interrupt for setup purposes
and later frees it and allocates the final number of MSI-X interrupts.
The following experimental change brought back the MSI-X interrupts.
This makes me think that somehow freeing a MSI-X interrupt doesn't
free it completely. I didn't see this behavior a few days ago,
therefore I think it's related to the recent changes to
irqdomain/genirq.
Didn't do a bisect yet, maybe you have an idea already.
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index a29b17070..8cc600819 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2381,7 +2381,7 @@ static int nvme_pci_enable(struct nvme_dev *dev)
* interrupts. Pre-enable a single MSIX or MSI vec for setup. We'll
* adjust this later.
*/
- result = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
+ result = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
if (result < 0)
return result;
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-06-09 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 18:43 Heiner Kallweit [this message]
2021-06-10 8:06 ` linux-next: NVME using PCI legacy interrupts only Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52371274-20bc-a150-a3ed-ba3e1305ad3e@gmail.com \
--to=hkallweit1@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox