Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: paul.grabinar@ranbarg.com (Paul Grabinar)
Subject: nvme_alloc_iod for discard requests
Date: Mon, 06 Oct 2014 19:20:59 +0100	[thread overview]
Message-ID: <5432DD8B.7050404@ranbarg.com> (raw)

Hi All,

A quick question/observation on the driver as in the 3.17 sources.

in nvme_submit_bio_queue we call nvme_alloc_iod passing in the size of
the request from the bio, so that the correct amount of space for the
PRPs can be allocated.
However, if this is a discard request, this size can be large, but I
think only the first entry is needed, as we use an entry from the
prp_small_pool, which holds the range.
Is there a reason why we don't just allocate a single entry for discard
operations?

I'm asking this as I am seeing an issue where we are trying to allocate
an order 3 atomic request, but the system does not have enough
contiguous atomic memory to complete the call and I believe the request
is actually a discard operation. This is not fatal, but it would be good
to remove the large allocation if it is not needed.

Thanks.

                 reply	other threads:[~2014-10-06 18:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5432DD8B.7050404@ranbarg.com \
    --to=paul.grabinar@ranbarg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox