Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] NVMe: make setup work for devices that don't do INTx
Date: Wed, 19 Nov 2014 20:36:15 -0700	[thread overview]
Message-ID: <546D61AF.6040403@fb.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1411191600480.4225@localhost.lm.intel.com>

On 11/19/2014 10:54 AM, Keith Busch wrote:
> On Fri, 14 Nov 2014, Jens Axboe wrote:
>> The setup/probe part currently relies on INTx being there and
>> working, that's not always the case. For devices that don't
>> advertise INTx, enable a single MSIx vector early on and disable
>> it again before we ask for our full range of queue vecs.
>
> Acked-by: Keith Busch <keith.busch at intel.com>
>
> I have an early sample platform that has the same behavior. I thought
> it was just a buggy prototype, but the h/w makers tell me it's designed
> that way.

I believe they are correct :-)

Thanks for the ack, I'll add this to the 3.19 mix. Did you take a look 
at the other two trivial patches?

-- 
Jens Axboe

  reply	other threads:[~2014-11-20  3:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 16:49 [PATCH] NVMe: make setup work for devices that don't do INTx Jens Axboe
2014-11-19 17:54 ` Keith Busch
2014-11-20  3:36   ` Jens Axboe [this message]
2014-11-20 16:55     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546D61AF.6040403@fb.com \
    --to=axboe@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox