From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCHv4] blk: Replace SG_GAPGS with new queue limits mask
Date: Tue, 1 Sep 2015 17:01:54 +0300 [thread overview]
Message-ID: <55E5AFD2.6080200@dev.mellanox.co.il> (raw)
In-Reply-To: <1438716733-566-1-git-send-email-keith.busch@intel.com>
> -static int req_gap_to_prev(struct request *req, struct request *next)
> +static int req_gap_to_prev(struct request *req, struct bio *next)
> {
> struct bio *prev = req->biotail;
>
> - return bvec_gap_to_prev(&prev->bi_io_vec[prev->bi_vcnt - 1],
> - next->bio->bi_io_vec[0].bv_offset);
> + return bvec_gap_to_prev(req->q, &prev->bi_io_vec[prev->bi_vcnt - 1],
> + next->bi_io_vec[1].bv_offset);
Keith,
is the index change in the bi_io_vec intentional?
next prev parent reply other threads:[~2015-09-01 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 19:32 [PATCHv4] blk: Replace SG_GAPGS with new queue limits mask Keith Busch
2015-08-05 1:45 ` Martin K. Petersen
2015-08-06 13:50 ` Christoph Hellwig
2015-08-19 19:12 ` Busch, Keith
2015-08-19 21:26 ` Jens Axboe
2015-08-06 17:36 ` Sagi Grimberg
2015-08-07 6:34 ` Christoph Hellwig
2015-09-01 14:01 ` Sagi Grimberg [this message]
2015-09-01 16:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5AFD2.6080200@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox