From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] blk: Fix bio_io_vec index when checking bvec gaps
Date: Tue, 1 Sep 2015 11:05:49 -0600 [thread overview]
Message-ID: <55E5DAED.2070101@fb.com> (raw)
In-Reply-To: <1441126004-19708-1-git-send-email-keith.busch@intel.com>
On 09/01/2015 10:46 AM, Keith Busch wrote:
> Corrects a coding error from earlier patch.
>
> Reported by: Sagi Grimberg <sagig at dev.mellanox.co.il>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> block/blk-merge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-merge.c b/block/blk-merge.c
> index 53bb485..d088cff 100644
> --- a/block/blk-merge.c
> +++ b/block/blk-merge.c
> @@ -488,7 +488,7 @@ static int req_gap_to_prev(struct request *req, struct bio *next)
> struct bio *prev = req->biotail;
>
> return bvec_gap_to_prev(req->q, &prev->bi_io_vec[prev->bi_vcnt - 1],
> - next->bi_io_vec[1].bv_offset);
> + next->bi_io_vec[0].bv_offset);
> }
Thanks - good catch, Sagi. I've applied this, and added a Fixes line as
well.
--
Jens Axboe
prev parent reply other threads:[~2015-09-01 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 16:46 [PATCH] blk: Fix bio_io_vec index when checking bvec gaps Keith Busch
2015-09-01 17:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5DAED.2070101@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).