* [PATCH] blk: Fix bio_io_vec index when checking bvec gaps
@ 2015-09-01 16:46 Keith Busch
2015-09-01 17:05 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2015-09-01 16:46 UTC (permalink / raw)
Corrects a coding error from earlier patch.
Reported by: Sagi Grimberg <sagig at dev.mellanox.co.il>
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
block/blk-merge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 53bb485..d088cff 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -488,7 +488,7 @@ static int req_gap_to_prev(struct request *req, struct bio *next)
struct bio *prev = req->biotail;
return bvec_gap_to_prev(req->q, &prev->bi_io_vec[prev->bi_vcnt - 1],
- next->bi_io_vec[1].bv_offset);
+ next->bi_io_vec[0].bv_offset);
}
static int ll_merge_requests_fn(struct request_queue *q, struct request *req,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] blk: Fix bio_io_vec index when checking bvec gaps
2015-09-01 16:46 [PATCH] blk: Fix bio_io_vec index when checking bvec gaps Keith Busch
@ 2015-09-01 17:05 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2015-09-01 17:05 UTC (permalink / raw)
On 09/01/2015 10:46 AM, Keith Busch wrote:
> Corrects a coding error from earlier patch.
>
> Reported by: Sagi Grimberg <sagig at dev.mellanox.co.il>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> block/blk-merge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-merge.c b/block/blk-merge.c
> index 53bb485..d088cff 100644
> --- a/block/blk-merge.c
> +++ b/block/blk-merge.c
> @@ -488,7 +488,7 @@ static int req_gap_to_prev(struct request *req, struct bio *next)
> struct bio *prev = req->biotail;
>
> return bvec_gap_to_prev(req->q, &prev->bi_io_vec[prev->bi_vcnt - 1],
> - next->bi_io_vec[1].bv_offset);
> + next->bi_io_vec[0].bv_offset);
> }
Thanks - good catch, Sagi. I've applied this, and added a Fixes line as
well.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-01 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-01 16:46 [PATCH] blk: Fix bio_io_vec index when checking bvec gaps Keith Busch
2015-09-01 17:05 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).