From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"oren@nvidia.com" <oren@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hch@lst.de" <hch@lst.de>
Cc: "israelr@nvidia.com" <israelr@nvidia.com>,
"nitzanc@nvidia.com" <nitzanc@nvidia.com>
Subject: Re: [PATCH 1/1] nvme: update enumerations for status codes
Date: Wed, 20 Jan 2021 12:02:58 +0200 [thread overview]
Message-ID: <55ebc8c7-5631-1f99-1384-80ca85c26b0d@nvidia.com> (raw)
In-Reply-To: <BYAPR04MB4965E1DC0180C2E5789E505186A20@BYAPR04MB4965.namprd04.prod.outlook.com>
On 1/20/2021 7:09 AM, Chaitanya Kulkarni wrote:
> Max,
> On 1/4/21 04:59, Max Gurtovoy wrote:
>> All the updates are mentioned in the ratified NVMe 1.4 spec.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
> I'm not against keeping the header file up to date with the spec,
> but should we add the error status into the kernel code even if
> we are not using it in the host/target driver ?
I we go with this approach we should remove half of the code inside nvme.h
>
> Here we add 24 lines which we have not used at all.
>> include/linux/nvme.h | 24 ++++++++++++++++++++----
>> 1 file changed, 20 insertions(+), 4 deletions(-)
>>
> Regarding the nvme-cli this is much needed a sync since it does
> decode all the errors if I'm not wrong.
I can sync it in V2.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-20 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 12:59 [PATCH 1/1] nvme: update enumerations for status codes Max Gurtovoy
2021-01-14 11:12 ` Hannes Reinecke
2021-01-14 17:52 ` Christoph Hellwig
2021-01-19 14:20 ` Max Gurtovoy
2021-01-20 5:09 ` Chaitanya Kulkarni
2021-01-20 10:02 ` Max Gurtovoy [this message]
2021-01-21 8:08 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ebc8c7-5631-1f99-1384-80ca85c26b0d@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nitzanc@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox