From mboxrd@z Thu Jan 1 00:00:00 1970 From: axboe@kernel.dk (Jens Axboe) Date: Fri, 11 May 2018 15:05:22 -0600 Subject: [PATCH v3] nvme: add quirk to force medium priority for SQ creation In-Reply-To: <20180511170252.GA7344@localhost.localdomain> References: <672a97be-7fbf-b21e-9f75-2c18e64ccf8f@kernel.dk> <20180508163539.GB31027@localhost.localdomain> <20180511170252.GA7344@localhost.localdomain> Message-ID: <5617cb00-dff4-8316-af05-e72d6c7f6304@kernel.dk> On 5/11/18 11:02 AM, Keith Busch wrote: > On Tue, May 08, 2018@10:35:39AM -0600, Keith Busch wrote: >> On Tue, May 08, 2018@10:25:15AM -0600, Jens Axboe wrote: >>> Some P3100 drives have a bug where they think WRRU (weighted round >>> robin) is always enabled, even though the host doesn't set it. Since >>> they think it's enabled, they also look at the submission queue >>> creation priority. We used to set that to MEDIUM by default, >>> but that was removed in commit 81c1cd98351b. This causes various >>> issues on that drive. Add a quick to still set MEDIUM priority >>> for that controller. >>> >>> Fixes: 81c1cd98351b ("nvme/pci: Don't set reserved SQ create flags") >>> Cc: stable at vger.kernel.org >>> Signed-off-by: Jens Axboe >> >> Thanks, applied to nvme-4.18. > > Actually, any concern if I apply for the next 4.17-rc instead? I know > this breakage isn't all that recent, but there seems to be heightened > visibility on getting this work-around to users. Fine with me, it's trivial and the sooner the better... -- Jens Axboe