From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] NVMe: Fix memory leak on retried commands
Date: Thu, 15 Oct 2015 13:40:46 -0600 [thread overview]
Message-ID: <5620013E.9020109@fb.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1510151904520.27742@localhost.lm.intel.com>
On 10/15/2015 01:34 PM, Keith Busch wrote:
> On Tue, 13 Oct 2015, Keith Busch wrote:
>> Resources are reallocated for requeued commands, so unmap and release
>> the iod for the failed command.
>
> Hi Jens,
>
> Since you're applying changes for 4.3, can you add this one? It's a
> pretty bad memory leak and causes a kernel hang if you remove a drive
> because of a busy dma pool. You'll get messages spewing like this:
>
> nvme 0000:xx:xx.x: dma_pool_destroy prp list 256, ffff880420dec000 busy
>
> and lock up pci and the driver since removal never completes while
> holding a lock.
Yeah, it's applied. It's hand applied since it no longer applied after
the error fixup from Christoph:
http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=0dfc70c33409afc232ef0b9ec210535dfbf9bc61
> I think this should go into stable back to 4.0. I'm not entirely sure how
> to do that. Will the Cc on the original achieve that when this is merged?
I think your patch is fine, it's marked stable and with 4.0 and up. So
should be no need to do anything else.
--
Jens Axboe
prev parent reply other threads:[~2015-10-15 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 22:13 [PATCH] NVMe: Fix memory leak on retried commands Keith Busch
2015-10-14 14:12 ` Christoph Hellwig
2015-10-15 19:34 ` Keith Busch
2015-10-15 19:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620013E.9020109@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).