linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Increase the max transfer size when mdts is 0
@ 2015-09-10 11:29 Sathyavathi M
  2015-09-10 13:48 ` Keith Busch
  0 siblings, 1 reply; 4+ messages in thread
From: Sathyavathi M @ 2015-09-10 11:29 UTC (permalink / raw)


From: Sathyavathi M <sathya.m@samsung.com>

This patch address the issue when IO with 128KB from FIO is splitted as two
parts, 124KB and 4KB due to max transfer size(127KB).This degrades the device
performance.

Signed-off-by: Sathyavathi M <sathya.m at samsung.com>
---
 drivers/block/nvme-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index b97fc3f..9bf6ea5 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2479,6 +2479,8 @@ static int nvme_dev_add(struct nvme_dev *dev)
 	memcpy(dev->firmware_rev, ctrl->fr, sizeof(ctrl->fr));
 	if (ctrl->mdts)
 		dev->max_hw_sectors = 1 << (ctrl->mdts + shift - 9);
+	else
+		dev->max_hw_sectors = UINT_MAX;
 	if ((pdev->vendor == PCI_VENDOR_ID_INTEL) &&
 			(pdev->device == 0x0953) && ctrl->vs[3]) {
 		unsigned int max_hw_sectors;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] Increase the max transfer size when mdts is 0
  2015-09-10 11:29 Sathyavathi M
@ 2015-09-10 13:48 ` Keith Busch
  0 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2015-09-10 13:48 UTC (permalink / raw)


On Thu, 10 Sep 2015, Sathyavathi M wrote:
> From: Sathyavathi M <sathya.m at samsung.com>
>
> This patch address the issue when IO with 128KB from FIO is splitted as two
> parts, 124KB and 4KB due to max transfer size(127KB).This degrades the device
> performance.
>
> Signed-off-by: Sathyavathi M <sathya.m at samsung.com>

Acked-by: Keith Busch <keith.busch at intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Increase the max transfer size when mdts is 0
@ 2015-11-05  5:17 Sathyavathi M
  2015-11-05 19:54 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Sathyavathi M @ 2015-11-05  5:17 UTC (permalink / raw)


Jens,

Can you please pull in the below patch.

Regards,
Sathya

------- Original Message -------
Sender : Sathyavathi M<sathya.m at samsung.com> Lead Engineer/SRI-Bangalore-SSD Solutions/Samsung Electronics
Date : Sep 10, 2015 20:29 (GMT+09:00)
Title : [PATCH] Increase the max transfer size when mdts is 0
On Thu, 10 Sep 2015, Sathyavathi M wrote:
> From: Sathyavathi M <sathya.m at samsung.com>
>
> This patch address the issue when IO with 128KB from FIO is splitted as two
> parts, 124KB and 4KB due to max transfer size(127KB).This degrades the device
> performance.
>
> Signed-off-by: Sathyavathi M <sathya.m at samsung.com>

Acked-by: Keith Busch <keith.busch at intel.com>

From: Sathyavathi M 

This patch address the issue when IO with 128KB from FIO is splitted as two
parts, 124KB and 4KB due to max transfer size(127KB).This degrades the device
performance.

Signed-off-by: Sathyavathi M 
---
drivers/block/nvme-core.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index b97fc3f..9bf6ea5 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2479,6 +2479,8 @@ static int nvme_dev_add(struct nvme_dev *dev)
memcpy(dev->firmware_rev, ctrl->fr, sizeof(ctrl->fr));
if (ctrl->mdts)
dev->max_hw_sectors = 1 << (ctrl->mdts + shift - 9);
+ else
+ dev->max_hw_sectors = UINT_MAX;
if ((pdev->vendor == PCI_VENDOR_ID_INTEL) &&
(pdev->device == 0x0953) && ctrl->vs[3]) {
unsigned int max_hw_sectors;
-- 
1.9.1



Regards,
Sathya

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] Increase the max transfer size when mdts is 0
  2015-11-05  5:17 [PATCH] Increase the max transfer size when mdts is 0 Sathyavathi M
@ 2015-11-05 19:54 ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2015-11-05 19:54 UTC (permalink / raw)


On 11/04/2015 10:17 PM, Sathyavathi M wrote:
> Jens,
>
> Can you please pull in the below patch.

Added manually, please double check:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=9ccc5e72d9180b19d37505b0b222110036958595

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-11-05 19:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-05  5:17 [PATCH] Increase the max transfer size when mdts is 0 Sathyavathi M
2015-11-05 19:54 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2015-09-10 11:29 Sathyavathi M
2015-09-10 13:48 ` Keith Busch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).