From: axboe@fb.com (Jens Axboe)
Subject: [patch] nvme: precedence bug in nvme_pr_clear()
Date: Wed, 9 Dec 2015 11:05:06 -0700 [thread overview]
Message-ID: <56686D52.5060900@fb.com> (raw)
In-Reply-To: <20151209180018.GA19448@lst.de>
On 12/09/2015 11:00 AM, Christoph Hellwig wrote:
> On Wed, Dec 09, 2015@10:56:37AM -0700, Jens Axboe wrote:
>> On 12/09/2015 03:24 AM, Dan Carpenter wrote:
>>> The "|" operator has higher precedence than "?:" so this didn't work as
>>> intended. I had previously fixed this bug, but it we copied the older
>>> unfixed version when we moved the function between files.
>>>
>>> Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code')
>>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>>
>> Dejavu, but I guess in a different function. Christoph, you are hereby
>> banned from ever using ?:!
>
> Nah, I'm banned from ever moving large chunks of code around again :)
> The orginal Bug is Keith's, I just undid the fix by not properly fixing
> up the code move for the conflict.
Alright you are off the hook, the ban will be instated in Keith instead :-)
--
Jens Axboe
next prev parent reply other threads:[~2015-12-09 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:24 [patch] nvme: precedence bug in nvme_pr_clear() Dan Carpenter
2015-12-09 17:56 ` Jens Axboe
2015-12-09 18:00 ` Christoph Hellwig
2015-12-09 18:05 ` Jens Axboe [this message]
2015-12-09 18:15 ` Keith Busch
2015-12-09 18:00 ` Keith Busch
2015-12-09 18:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56686D52.5060900@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox