From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH RFC 3/4] nvme: Move IO termination code to the core
Date: Thu, 24 Dec 2015 16:53:16 +0200 [thread overview]
Message-ID: <567C06DC.10904@dev.mellanox.co.il> (raw)
In-Reply-To: <20151224142528.GD2646@infradead.org>
>> +void nvme_fail_admin_cmds(struct nvme_ctrl *ctrl,
>> + busy_tag_iter_fn *terminate_io, void *priv)
>> +{
>> + blk_mq_tagset_busy_iter(ctrl->admin_tagset, terminate_io, priv);
>> +}
>> +EXPORT_SYMBOL_GPL(nvme_fail_admin_cmds);
>> +
>> +void nvme_fail_io_cmds(struct nvme_ctrl *ctrl,
>> + busy_tag_iter_fn *terminate_io, void *priv)
>> +{
>> + blk_mq_tagset_busy_iter(ctrl->tagset, terminate_io, priv);
>> +}
>> +EXPORT_SYMBOL_GPL(nvme_fail_io_cmds);
>
> But I see absolutely no point for these helpers. These are trivial
> one-liners that can stay in the transport drivers. And with that we
> also don't need the admin_tagset pointer in the generic controller
> (at least yet..)
I just figured that it'd be nice to have a meaningfully named helpers,
it's not uncommon in the kernel...
I have no problem losing them anyways so unless someone votes to keep
them I'll remove them in v1.
next prev parent reply other threads:[~2015-12-24 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 11:23 [PATCH RFC 0/4] Move active IO termination to the core Sagi Grimberg
2015-12-24 11:23 ` [PATCH RFC 1/4] blk-mq: Export a busy tagset iterator helper Sagi Grimberg
2015-12-24 14:24 ` Christoph Hellwig
2015-12-24 14:50 ` Sagi Grimberg
2015-12-24 11:23 ` [PATCH RFC 2/4] nvme: Add a controller reference to the admin tagset Sagi Grimberg
2015-12-24 11:24 ` [PATCH RFC 3/4] nvme: Move IO termination code to the core Sagi Grimberg
2015-12-24 14:25 ` Christoph Hellwig
2015-12-24 14:53 ` Sagi Grimberg [this message]
2015-12-24 14:56 ` Christoph Hellwig
2015-12-24 11:24 ` [PATCH RFC 4/4] blk-mq: Make blk_mq_all_tag_busy_iter static Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567C06DC.10904@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox