From: m@bjorling.me (Matias Bjørling)
Subject: [PATCH] nvme: return the whole CQE through the request passthrough interface
Date: Mon, 8 Feb 2016 20:47:42 +0100 [thread overview]
Message-ID: <56B8F0DE.5090808@bjorling.me> (raw)
In-Reply-To: <1454954988-32306-2-git-send-email-hch@lst.de>
> req = blk_mq_tag_to_rq(*nvmeq->tags, cqe.command_id);
> - if (req->cmd_type == REQ_TYPE_DRV_PRIV) {
> - u32 result = le32_to_cpu(cqe.result);
> - req->special = (void *)(uintptr_t)result;
> - }
> + if (req->cmd_type == REQ_TYPE_DRV_PRIV && req->special)
> + memcpy(req->special, &cqe, sizeof(cqe));
Thanks for sending the patch.
When LightNVM send asynchronous data commands, it would need to allocate
extra memory for cqe. Would it make sense to pass cqe directly and
assume that it is live through the blk_mq_complete_request call?
next prev parent reply other threads:[~2016-02-08 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 18:09 nvme: return the whole CQE through the request passthrough interface Christoph Hellwig
2016-02-08 18:09 ` [PATCH] " Christoph Hellwig
2016-02-08 19:47 ` Matias Bjørling [this message]
2016-02-09 12:46 ` Christoph Hellwig
2016-02-09 13:05 ` Matias Bjørling
2016-02-13 10:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8F0DE.5090808@bjorling.me \
--to=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).