From: axboe@fb.com (Jens Axboe)
Subject: [PATCH 2/2] NVMe: Remove unused sq_head read in completion path
Date: Tue, 8 Mar 2016 10:41:10 -0700 [thread overview]
Message-ID: <56DF0EB6.1000901@fb.com> (raw)
In-Reply-To: <1457458494-10550-3-git-send-email-jonathan.derrick@intel.com>
On 03/08/2016 10:34 AM, Jon Derrick wrote:
> Signed-off-by: Jon Derrick <jonathan.derrick at intel.com>
> ---
> drivers/nvme/host/pci.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 74514c7..e9f18e1 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -134,7 +134,6 @@ struct nvme_queue {
> u32 __iomem *q_db;
> u16 q_depth;
> s16 cq_vector;
> - u16 sq_head;
> u16 sq_tail;
> u16 cq_head;
> u16 qid;
> @@ -719,7 +718,6 @@ static void __nvme_process_cq(struct nvme_queue *nvmeq, unsigned int *tag)
>
> if ((status & 1) != phase)
> break;
> - nvmeq->sq_head = le16_to_cpu(cqe.sq_head);
> if (++head == nvmeq->q_depth) {
> head = 0;
> phase = !phase;
This seems like a no-brainer, good spotting.
--
Jens Axboe
next prev parent reply other threads:[~2016-03-08 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 17:34 [PATCH 0/2] Some performance fixes for fastpath Jon Derrick
2016-03-08 17:34 ` [PATCH 1/2] Block: Disable polling stats when iostats are disabled Jon Derrick
2016-03-08 17:38 ` Sagi Grimberg
2016-03-08 17:58 ` Jon Derrick
2016-03-08 17:40 ` Jens Axboe
2016-03-08 18:02 ` Jon Derrick
2016-03-08 17:34 ` [PATCH 2/2] NVMe: Remove unused sq_head read in completion path Jon Derrick
2016-03-08 17:40 ` Sagi Grimberg
2016-03-08 17:41 ` Jens Axboe [this message]
2016-03-09 7:54 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF0EB6.1000901@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox