From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme_fc: avoid workqueue flush stalls
Date: Sun, 22 Oct 2017 13:05:19 +0300 [thread overview]
Message-ID: <56c72dfe-132f-f219-3d50-c7775a84a209@grimberg.me> (raw)
In-Reply-To: <327c6f13-0bd3-5e95-a9e5-d104c561680d@broadcom.com>
>>> There's no need to wait for the full nvme_wq, which is now shared,
>>> to flush. flush only the delete_work item.
>>
>> The patch looks correct, but can you explain what stalled that this
>> patch fixes?
>
> I don't have an explicit failure case. While reviewing the code for the
> other stall issue with fatal_err_work, I realized that this flush is now
> waiting on a work queue shared by everything nvmf.? It used to be solely
> a nvme-fc transport workqueue. There's no need for waiting on anything
> more than the delete work item. And having it raise in scope of the nvmf
> thread perhaps makes it wait for a lot of other unnecessary things -
> slowing it down.
>
> If you're ok with it - can you Ack/Review it ?
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
prev parent reply other threads:[~2017-10-22 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 16:56 [PATCH] nvme_fc: avoid workqueue flush stalls James Smart
2017-09-30 17:18 ` Sagi Grimberg
2017-10-19 20:24 ` James Smart
2017-10-22 10:05 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c72dfe-132f-f219-3d50-c7775a84a209@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).