From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] NVMe: Always use MSI/MSI-x interrupts
Date: Mon, 11 Apr 2016 10:02:37 -0600 [thread overview]
Message-ID: <570BCA9D.4060807@fb.com> (raw)
In-Reply-To: <1460153350-4992-1-git-send-email-keith.busch@intel.com>
On 04/08/2016 04:09 PM, Keith Busch wrote:
> Multiple users have reported device initialization failure due the driver
> not receiving legacy PCI interrupts. This is not unique to any particular
> controller, but has been observed on multiple platforms.
>
> There have been no issues reported or observed when with message signaled
> interrupts, so this patch attempts to use MSI-x during initialization,
> falling back to MSI. If that fails, legacy would become the default.
>
> The setup_io_queues error handling had to change as a result: the admin
> queue's msix_entry used to be initialized to the legacy IRQ. The case
> where nr_io_queues is 0 would fail request_irq when setting up the admin
> queue's interrupt since re-enabling MSI-x fails with 0 vectors, leaving
> the admin queue's msix_entry invalid. Instead, return success immediately.
Added for 4.7.
--
Jens Axboe
prev parent reply other threads:[~2016-04-11 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 22:09 [PATCH] NVMe: Always use MSI/MSI-x interrupts Keith Busch
2016-04-08 23:11 ` Christoph Hellwig
2016-04-11 16:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BCA9D.4060807@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox