[PATCH v2] nvme: Avoid reset work on watchdog timer function during error recovery

[gpiccoli@linux.vnet.ibm.com (Guilherme G. Piccoli)]

On 04/13/2016 03:03 AM, Jens Axboe wrote:
> On 04/12/2016 11:22 PM, Jens Axboe wrote:
>> On 04/12/2016 05:32 PM, Guilherme G. Piccoli wrote:
>>> This patch adds a check on nvme_watchdog_timer() function to avoid the
>>> call to reset_work() when an error recovery process is ongoing on
>>> controller. The check is made by looking at pci_channel_offline()
>>> result.
>>>
>>> If we don't check for this on nvme_watchdog_timer(), error recovery
>>> mechanism can't recover well, because reset_work() won't be able to
>>> do its job (since we're in the middle of an error) and so the
>>> controller is removed from the system before error recovery mechanism
>>> can perform slot reset (which would allow the adapter to recover).
>>>
>>> In this patch we also have splitted the huge condition expression in
>>> nvme_watchdog_timer() by introducing an auxiliary function to help
>>> make the code more readable.
>>
>> Added for 4.7, thanks.
>
> And dropped again, please at least verify that patches don't introduce
> new warnings. You're adding a nssro bool, that then never gets used. Did
> you test this version?
>

I'm very sorry Jens, totally my fault. The patch was tested and it's 
working fine. I just...forgot to check compilation warnings and to use 
the checkpatch script :(

Just sent a v3 correcting the issue you pointed and some minor issues 
the checkpatch script pointed. The v3 was re-tested too!

Thanks,


Guilherme