From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 2/5] nvme: introduce a controller state machine
Date: Tue, 19 Apr 2016 21:35:20 +0300 [thread overview]
Message-ID: <57167A68.5050206@grimberg.me> (raw)
In-Reply-To: <20160419182545.GA989@lst.de>
>>>>> - clear_bit(NVME_CTRL_RESETTING, &dev->flags);
>>>>> + if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_LIVE)) {
>>>>> + dev_warn(dev->ctrl.device, "failed to mark controller live\n");
>>>>> + goto out;
>>>>> + }
>>>>> return;
>>>>>
>>>>> out:
>>>>
>>>> You're missing a state change before removing a
>>>> dead controller...
>>>
>>> why?
>>
>> Just to have the state consistent with what the driver
>> is doing. Not a must though...
>
> Let's allocate states on an as needed basis and avoid that new
> state for now.
Didn't mean a new state, just a transition to NVME_CTRL_DELETING
if nvme_reset_work fails...
next prev parent reply other threads:[~2016-04-19 18:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 12:34 proper controller state machine and more common code Christoph Hellwig
2016-04-18 12:34 ` [PATCH 1/5] nvme: remove the io_incapable method Christoph Hellwig
2016-04-18 12:34 ` [PATCH 2/5] nvme: introduce a controller state machine Christoph Hellwig
2016-04-18 18:36 ` Sagi Grimberg
2016-04-18 20:17 ` Christoph Hellwig
2016-04-18 20:30 ` Sagi Grimberg
2016-04-19 18:25 ` Christoph Hellwig
2016-04-19 18:35 ` Sagi Grimberg [this message]
2016-04-19 18:37 ` Christoph Hellwig
2016-04-20 17:25 ` Sagi Grimberg
2016-04-18 12:34 ` [PATCH 3/5] nvme: tighten up state check for namespace scanning Christoph Hellwig
2016-04-18 18:40 ` Sagi Grimberg
2016-04-18 12:34 ` [PATCH 4/5] nvme: move namespace scanning to core Christoph Hellwig
2016-04-18 18:46 ` Sagi Grimberg
2016-04-18 18:49 ` Keith Busch
2016-04-18 19:41 ` Sagi Grimberg
2016-04-18 20:17 ` Christoph Hellwig
2016-04-18 12:34 ` [PATCH 5/5] nvme: move AER handling to common code Christoph Hellwig
2016-04-20 17:26 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2016-04-26 11:51 proper controller state machine and more common code V2 Christoph Hellwig
2016-04-26 11:51 ` [PATCH 2/5] nvme: introduce a controller state machine Christoph Hellwig
2016-04-26 16:18 ` Jon Derrick
2016-04-27 7:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57167A68.5050206@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox