From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57F61C0218D for ; Fri, 31 Jan 2025 10:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:In-Reply-To:From:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=loFgrXWvJRjGfwH8zqXYCRcdDPp53/pl9iAISReaC8Q=; b=35fyW+umyWYJB2BwOJ+yO9e1LY ZwYzTzVE7t7KTg+WIjN2ktFKEmYaN1elU4VaPa3rnsvhrwEdMW7pjYVFzxikd7XNdVFD0j6tsfyWg x0r6hBym6LnDfwmyLviMi8q4p7U1GNBafYwwCS9DMpUn1/Y+FRQmV6HwwNjzctUvC2b3rTem/0WDa ozIEP15+Rd1XMP+9KoPZ2sIXmLYePei5ZrmtH9tuGJsjdQZyLgnJrbR9B58WY2av1hsrE9Gp+i94X zWh/ciKF8K/kgWelJ/dhCcNHe9ajDU4qd9d6bNu95sTU5b/eGEoHQM7LfDpBgog60DdynnRdOrY3w cHclPAag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdo7P-0000000ANTK-1WMt; Fri, 31 Jan 2025 10:19:23 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdo7M-0000000ANSW-2Yp5 for linux-nvme@lists.infradead.org; Fri, 31 Jan 2025 10:19:22 +0000 Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250131101913epoutp038e3a49d08f9319b4782a40714e32951c~fv7IkJcfB1521915219epoutp03P for ; Fri, 31 Jan 2025 10:19:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250131101913epoutp038e3a49d08f9319b4782a40714e32951c~fv7IkJcfB1521915219epoutp03P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1738318753; bh=loFgrXWvJRjGfwH8zqXYCRcdDPp53/pl9iAISReaC8Q=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=OBifgiPFc2wsXmbCa6hJs1NFM+pdQ6Hfihb2FJ+RqPKuealy10eAn5zvzgqR7wugC Q7SQDlKEcYc9wLy0IAcJjALHvls6cUHJPQeIwrDKO1y1WX+DmX+q9dVOEegGen1c8S QJp/5TX7XMF2YcGnwVUcc+/7fGbg7TTGM7YKCJck= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas5p4.samsung.com (KnoxPortal) with ESMTP id 20250131101912epcas5p47465e0145a30e4e8ca42a0648ec96fe5~fv7IBaLme2409324093epcas5p4K; Fri, 31 Jan 2025 10:19:12 +0000 (GMT) Received: from epsmges5p3new.samsung.com (unknown [182.195.38.182]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4YksLk74vkz4x9Pq; Fri, 31 Jan 2025 10:19:10 +0000 (GMT) Received: from epcas5p4.samsung.com ( [182.195.41.42]) by epsmges5p3new.samsung.com (Symantec Messaging Gateway) with SMTP id FB.92.19956.E93AC976; Fri, 31 Jan 2025 19:19:10 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20250131101910epcas5p2e96869da67bdec816c5618af024f7dc5~fv7GDL7wT0831608316epcas5p2N; Fri, 31 Jan 2025 10:19:10 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250131101910epsmtrp2f0fe3baf733867b241ffdf528f4e8903~fv7GCYZbU0217902179epsmtrp2D; Fri, 31 Jan 2025 10:19:10 +0000 (GMT) X-AuditID: b6c32a4b-fd1f170000004df4-5e-679ca39ed390 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id AB.E6.33707.E93AC976; Fri, 31 Jan 2025 19:19:10 +0900 (KST) Received: from [107.122.11.51] (unknown [107.122.11.51]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250131101908epsmtip2d6d722168bf3a34eedda59ee873b8158~fv7EZsGqL1640116401epsmtip2V; Fri, 31 Jan 2025 10:19:08 +0000 (GMT) Message-ID: <572e0418-de26-47ec-b536-b63291acff52@samsung.com> Date: Fri, 31 Jan 2025 15:49:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 0/3] Btrfs checksum offload To: Johannes Thumshirn , "josef@toxicpanda.com" , "dsterba@suse.com" , "clm@fb.com" , "axboe@kernel.dk" , "kbusch@kernel.org" , hch Cc: "linux-btrfs@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "gost.dev@samsung.com" Content-Language: en-US From: Kanchan Joshi In-Reply-To: <299a886d-c065-4b75-b0be-625710f7348c@wdc.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCJsWRmVeSWpSXmKPExsWy7bCmlu68xXPSDWbtM7FYfbefzWJS/wx2 iws/Gpksbh7YyWSxcvVRJou/XfeYLP48NLSYdOgao8XeW9oWlx6vYLeYv+wpuwO3x8Tmd+we l8+Wemxa1cnmsXlJvcfumw1sHn1bVjF6rN9ylcVjwuaNrB6fN8l5tB/oZgrgisq2yUhNTEkt UkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAG6V0mhLDGnFCgUkFhc rKRvZ1OUX1qSqpCRX1xiq5RakJJTYFKgV5yYW1yal66Xl1piZWhgYGQKVJiQnbGrpYup4C1H xbXJE1gbGP+zdTFyckgImEg83/6LpYuRi0NIYDejxOTmF4wQzidGiVWrPrDCOdt3/mWEafnV 0MoGkdjJKLH3x3OoqreMEhOnzWEBqeIVsJM4vesK2BIWAVWJu+1rWCHighInZz4BqxEVkJe4 f2sGexcjO4ewgK7EjmiQMSICXUwSh9csB5vJLPCFUeLH8yNgvcwC4hK3nsxn6mLk4GAT0JS4 MLkUJMwpYC2xs3ELE0SJvMT2t3OYQXolBI5wSJy4OZUd4moXibOL9kJ9ICzx6vgWqLiUxOd3 e6GBkS3x4NEDFgi7RmLH5j5WCNteouHPDVaQvcxAe9fv0ofYxSfR+/sJ2DkSArwSHW1CENWK EvcmPYXqFJd4OGMJlO0h8WLCMWi47WWUeHjsFdMERoVZSKEyC8mXs5C8Mwth8wJGllWMkqkF xbnpqcWmBcZ5qeXwCE/Oz93ECE7OWt47GB89+KB3iJGJg/EQowQHs5IIb+y5GelCvCmJlVWp RfnxRaU5qcWHGE2B0TORWUo0OR+YH/JK4g1NLA1MzMzMTCyNzQyVxHmbd7akCwmkJ5akZqem FqQWwfQxcXBKNTDF3tNrCuR3KuGWONs91T3BTnNqV0MhZ/WB3UJeArOvC9w/uzBwmv2/uoTC hg25DM9WHq5p4lx1mVN8owFba0z/MTHNyGqNc6d/5aq6Mm9XXNQnqPbKyd/lnoVjgUj8+hSx T8eDwo7zzuXqfLonX8cjZlX0wZclJ18+mfFgloXNzORtsosEY17/09ylZCjSoSLmM2F95umn B87JfJ59lFNOfNemij8bBOpefF0WJJXJ0mq3ntufeeq0Ta0tjfn8784b7RfK2vCsnPXnzvMt 4UU9N2WPGM7zkpjReVb2u3ah/tvvL+YZf3tY9vRagMTEJUfyVm/1Nb459+APllUVMlwcy9Z8 UOVIkJjfW/72Xr0SS3FGoqEWc1FxIgCnwsnhVwQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWy7bCSvO68xXPSDVau5bJYfbefzWJS/wx2 iws/Gpksbh7YyWSxcvVRJou/XfeYLP48NLSYdOgao8XeW9oWlx6vYLeYv+wpuwO3x8Tmd+we l8+Wemxa1cnmsXlJvcfumw1sHn1bVjF6rN9ylcVjwuaNrB6fN8l5tB/oZgrgiuKySUnNySxL LdK3S+DK2NXSxVTwlqPi2uQJrA2M/9m6GDk5JARMJH41tALZXBxCAtsZJb48+soIkRCXaL72 gx3CFpZY+e85O0TRa0aJt7+PsoIkeAXsJE7vugI2iUVAVeJu+xqouKDEyZlPWEBsUQF5ifu3 ZgA1s3MIC+hK7IgGGSMi0MMkce78LkYQh1ngC6PEzmtXGSEW7GWUeH5uCdgVzEBX3Hoyn6mL kYODTUBT4sLkUpAwp4C1xM7GLUwQJWYSXVu7oMrlJba/ncM8gVFoFpIzZiGZNAtJyywkLQsY WVYxiqYWFOem5yYXGOoVJ+YWl+al6yXn525iBEegVtAOxmXr/+odYmTiYDzEKMHBrCTCG3tu RroQb0piZVVqUX58UWlOavEhRmkOFiVxXuWczhQhgfTEktTs1NSC1CKYLBMHp1QD00rNivLN L2OkXl/mUPli7PpQlGFN3/+zzZGmNQ/+54Vorjy+4Z6wKdPVpbOKDfZUr1u11lK9/4/Bwt9G e71V158/k9vnuXjWv6cZJxNeWvVUriwvc8+QX3Cz96jZ9Oud1bFsy/5UpHbt+pLHYlE2ueu/ hGPfnEX5e6Zca82J8Xz/wV6UlYPp/oz1ai/38e8/3r2zwOHf3O/CJ/qEGT1KDR8lTlUWNtfX Wq91K+L7cu1Nih9vPGC8u8vg9it3uYexb9YJeF0t/vBxh7ZQs8S5iykrko7lG/E3GoRaWPMr HQ7s2/7de9or788cbnKHGWzK/ngyfwwIS5Ou2pIZ8Pmjpa7KLQvHqb3catmv+y/8UGIpzkg0 1GIuKk4EAC0pFDEvAwAA X-CMS-MailID: 20250131101910epcas5p2e96869da67bdec816c5618af024f7dc5 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250129141039epcas5p11feb1be4124c0db3c5223325924183a3 References: <20250129140207.22718-1-joshi.k@samsung.com> <299a886d-c065-4b75-b0be-625710f7348c@wdc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_021921_123032_3A0947C3 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/29/2025 8:25 PM, Johannes Thumshirn wrote: > For instance if we get a checksum error on btrfs we not only report in > in dmesg, but also try to repair the affected sector if we do have a > data profile with redundancy. > > So while this patchset offloads the submission side work of the checksum > tree to the PI code, I don't see the back-propagation of the errors into > btrfs and the triggering of the repair code. > > I get it's a RFC, but as it is now it essentially breaks functionality > we rely on. Can you add this part as well so we can evaluate the > patchset not only from the write but also from the read side. I tested the series for read, but only the success cases. In this case checksum generation/verification happens only within the device. It was slightly tricky to inject an error and I skipped that. Since separate checksum I/Os are omitted, this is about handling the error condition in data read I/O path itself. I have not yet checked if repair code triggers when Btrfs is working with existing 'nodatasum' mount option. But I get your point that this needs to be handled.