From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH for-4.7] nvme: Remove RCU namespace protection
Date: Wed, 22 Jun 2016 13:04:36 +0300 [thread overview]
Message-ID: <576A62B4.3000208@grimberg.me> (raw)
In-Reply-To: <1466548365-992-1-git-send-email-keith.busch@intel.com>
> We can't sleep with RCU read lock held, but we need to do potentially
> blocking stuff to namespaces while traversing the list.
>
> This patch removes the rcu read locking to make this work, and leverages
> how namespace list manipulation currently occurs in order to be safe. Only
> scan work, reset work, or device removal can manipulate the namespace
> list, and none of those can execute at the same time. So, this patch
> locks the namespace list mutex only when the list is being changed,
> or when iterating the list by a non-IO task, like controller reset. We
> can't hold the lock for IO because we won't be able to clean up IO
> if it fails, so all those paths rely on the state machine to prevent
> two tasks from corrupting the list.
>
> This fixes these two BUGs:
This looks much better Keith,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
next prev parent reply other threads:[~2016-06-22 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 22:32 [PATCH for-4.7] nvme: Remove RCU namespace protection Keith Busch
2016-06-21 22:43 ` Keith Busch
2016-06-22 10:04 ` Sagi Grimberg [this message]
2016-06-22 16:13 ` Christoph Hellwig
2016-06-22 17:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A62B4.3000208@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox