linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCHv3 for-4.7] nvme: Remove RCU namespace protection
Date: Wed, 13 Jul 2016 09:41:25 -0700	[thread overview]
Message-ID: <57866F35.9090709@kernel.dk> (raw)
In-Reply-To: <20160713164858.GA20963@localhost.localdomain>

On 07/13/2016 09:48 AM, Keith Busch wrote:
> On Wed, Jul 13, 2016@09:24:33AM -0700, Jens Axboe wrote:
>> On 07/12/2016 07:22 PM, Christoph Hellwig wrote:
>>> On Tue, Jul 12, 2016@04:15:13PM -0700, Jens Axboe wrote:
>>>> I'm going back and forth on this... This isn't a regression for 4.7, is it?
>>>> If so, I'd be a lot more comfortable queuing this up for 4.8 (marked stable)
>>>> instead. It'll be another late addition, causing issues when it comes time
>>>> to merge for-4.8/drivers in the next merge window.
>>>
>>> It's a 4.7 regression.
>>
>> Two questions, then:
>>
>> 1) Why isn't it marked as such? Should have a Fixes tag.
>
> Sorry, my fault. I missed appending the "fixes" in later revisions as
> this evovled. Should have:
>
>    Reported-by: Ming Lin <mlin at kernel.org>
>    [fixes 0bf77e9 nvme: switch to RCU freeing the namespace]
>
>> 2) It's so large... Not really a question, other than, how can we make it
>> smaller/more contained?
>
> Fair enough. Part of the changes are not absolutely necessary (the
> ordered insertion, for example). I'll resend a smaller patch with
> the appropriate tags.

Thanks, please do. The smaller, the better...

-- 
Jens Axboe

      reply	other threads:[~2016-07-13 16:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 17:22 [PATCHv3 for-4.7] nvme: Remove RCU namespace protection Keith Busch
2016-07-09  1:07 ` Keith Busch
2016-07-10  9:47   ` Christoph Hellwig
2016-07-11 14:25     ` Keith Busch
2016-07-12 23:15   ` Jens Axboe
2016-07-13  2:22     ` Christoph Hellwig
2016-07-13 16:24       ` Jens Axboe
2016-07-13 16:48         ` Keith Busch
2016-07-13 16:41           ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57866F35.9090709@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).