Re: [PATCH net] nvme-tcp: Fix comma-related oops

patchwork-bot+netdevbpf
2023-07-02T14:50:33Z

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 29 Jun 2023 22:47:53 +0100 you wrote:
> Fix a comma that should be a semicolon. The comma is at the end of an
> if-body and thus makes the statement after (a bvec_set_page()) conditional
> too, resulting in an oops because we didn't fill out the bio_vec[]:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000008
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> ...
> Workqueue: nvme_tcp_wq nvme_tcp_io_work [nvme_tcp]
> RIP: 0010:skb_splice_from_iter+0xf1/0x370
> ...
> Call Trace:
> tcp_sendmsg_locked+0x3a6/0xdd0
> tcp_sendmsg+0x31/0x50
> inet_sendmsg+0x47/0x80
> sock_sendmsg+0x99/0xb0
> nvme_tcp_try_send_data+0x149/0x490 [nvme_tcp]
> nvme_tcp_try_send+0x1b7/0x300 [nvme_tcp]
> nvme_tcp_io_work+0x40/0xc0 [nvme_tcp]
> process_one_work+0x21c/0x430
> worker_thread+0x54/0x3e0
> kthread+0xf8/0x130
>
> [...]

Here is the summary with links:
- [net] nvme-tcp: Fix comma-related oops
https://git.kernel.org/netdev/net/c/c97d3fb9e0e7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.