From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28E08C7618E for ; Mon, 24 Apr 2023 06:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R/dJBKipj2BTYlAHwALrSBvABtFqG0TvrGDD9iTnPQE=; b=ucPMLeTkYKazGWhj2NA30S4aHN gQQ5kpmhvedDag7s3VwjgHh5ME6goJvzlA4BOy/1xW/0xzeQ0bv1Tk9an8ew//NyDsSX8DFD7qGLh jO0o7X6evG/sWrl1oc9tIcwajgeixF3KX5qsrghFmegjDD20KDEpEsqfEfe1m9u7jQNBGyzeEaUAs GT+DZVGIk85i+5XQK/gjbx4IxhUmuvXvXIB23N8IymITpFLZLrjY3zC9hgCZn/fSdpo4Ywknnw9D+ UGYIi8qCi71/uYU2x31mEP6G6tHIAWdZbCNju0NbiemSLkVhfM3tqIEsg8n6iqbfAgY9T/L6nmgYX Z3+rHhNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pqpPq-00FSB9-2f; Mon, 24 Apr 2023 06:11:10 +0000 Received: from smtp-out2.suse.de ([195.135.220.29]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pqpPo-00FS9s-2f for linux-nvme@lists.infradead.org; Mon, 24 Apr 2023 06:11:10 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 889181FD7B; Mon, 24 Apr 2023 06:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682316660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/dJBKipj2BTYlAHwALrSBvABtFqG0TvrGDD9iTnPQE=; b=odY6KUD+HvzBFk5FATpkTmwmlDN4b/LjIeJY36wvs58PftePjyBOI96nhM1RGwbP7+LKwH YdY7XeFH+tXCQ2y3pBCiO1z+bpaL+C5pCpeQkB5/328AaXoStq8EpJ7hQwwsKwehVG5c7x wIBWZtEv01tz09D8LIGgzkk9MW+3nn0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682316660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/dJBKipj2BTYlAHwALrSBvABtFqG0TvrGDD9iTnPQE=; b=sXmMQxHxR+heL5M0+44KuS3Bg25M7m3SagAFUNxEANoaAnn5taAdc/uXETxV5XShElqMKw mbV2+7femH7VdABw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2E95513780; Mon, 24 Apr 2023 06:11:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0351CXQdRmTHIAAAMHmgww (envelope-from ); Mon, 24 Apr 2023 06:11:00 +0000 Message-ID: <5b7ca121-2b85-ddd0-d94b-1739cc5dcbec@suse.de> Date: Mon, 24 Apr 2023 08:10:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 0/2] Fix failover to non integrity NVMe path Content-Language: en-US To: Christoph Hellwig , Max Gurtovoy Cc: martin.petersen@oracle.com, sagi@grimberg.me, linux-nvme@lists.infradead.org, kbusch@kernel.org, axboe@kernel.dk, linux-block@vger.kernel.org, oren@nvidia.com, oevron@nvidia.com, israelr@nvidia.com References: <20230423141330.40437-1-mgurtovoy@nvidia.com> <20230424051144.GA9288@lst.de> From: Hannes Reinecke In-Reply-To: <20230424051144.GA9288@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230423_231109_037184_52AD2A92 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 4/24/23 07:11, Christoph Hellwig wrote: > On Sun, Apr 23, 2023 at 05:13:28PM +0300, Max Gurtovoy wrote: >> Hi Christoph/Sagi/Martin, >> >> We're encountered a crash while testing failover between NVMeF/RDMA >> paths to a target that expose a namespace with metadata. The scenario is >> the following: >> Configure one initiator/host path on PI offload capable port (e.g ConnectX-5 >> device) and configure second initiator/host path on non PI offload capable >> port (e.g ConnectX-3). > > Hmm. I suspect the right thing to do here is to just fail the second > connect. Yeah, I'm slightly unhappy with this whole setup. If we were just doing DIF I guess the setup could work, but then we have to disable DIX (as we cannot support integrity data on the non-PI path). But we would need an additional patch to disable DIX functionality in those cases. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman