From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 3/7] nvme-fc: remove unused poll implementation
Date: Mon, 19 Nov 2018 08:19:07 -0700 [thread overview]
Message-ID: <5badecdb-cd80-c1ab-bb9d-72880800bb1c@kernel.dk> (raw)
In-Reply-To: <20181119075904.GC9622@infradead.org>
On 11/19/18 12:59 AM, Christoph Hellwig wrote:
> On Sat, Nov 17, 2018@02:43:50PM -0700, Jens Axboe wrote:
>> This relies on the fc taget ops setting ->poll_queue, which
>> nobody does. Otherwise it just checks if something has
>> completed, which isn't very useful.
>
> Please also remove the unused ->poll_queue method.
>
> Otherwise looks fine:
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
Sure, will do.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-19 15:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 21:43 [PATCHSET v4] Various block optimizations Jens Axboe
2018-11-17 21:43 ` [PATCH 1/7] block: avoid ordered task state change for polled IO Jens Axboe
2018-11-19 7:58 ` Christoph Hellwig
2018-11-17 21:43 ` [PATCH 2/7] block: have ->poll_fn() return number of entries polled Jens Axboe
2018-11-19 7:58 ` Christoph Hellwig
2018-11-25 10:52 ` Sagi Grimberg
2018-11-25 13:41 ` Jens Axboe
2018-11-27 10:10 ` Sagi Grimberg
2018-11-27 15:20 ` Jens Axboe
2018-11-17 21:43 ` [PATCH 3/7] nvme-fc: remove unused poll implementation Jens Axboe
2018-11-19 7:59 ` Christoph Hellwig
2018-11-19 15:19 ` Jens Axboe [this message]
2018-11-19 19:00 ` James Smart
2018-11-17 21:43 ` [PATCH 4/7] blk-mq: when polling for IO, look for any completion Jens Axboe
2018-11-19 8:02 ` Christoph Hellwig
2018-11-19 15:20 ` Jens Axboe
2018-11-17 21:43 ` [PATCH 5/7] blk-mq: remove 'tag' parameter from mq_ops->poll() Jens Axboe
2018-11-19 8:02 ` Christoph Hellwig
2018-11-17 21:43 ` [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not Jens Axboe
2018-11-19 8:05 ` Christoph Hellwig
2018-11-19 15:21 ` Jens Axboe
2018-11-20 9:11 ` Sagi Grimberg
2018-11-17 21:43 ` [PATCH 7/7] blk-mq: ensure mq_ops ->poll() is entered at least once Jens Axboe
2018-11-19 8:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5badecdb-cd80-c1ab-bb9d-72880800bb1c@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).