From: Nilay Shroff <nilay@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org,
sagi@grimberg.me, gjoyce@linux.ibm.com, chaitanyak@nvidia.com
Subject: Re: [PATCH 1/2] nvmet: introduce struct nvmet_passthru
Date: Mon, 28 Sep 2026 12:05:10 +0530 [thread overview]
Message-ID: <5d763307-ebd4-4d30-8a69-04f418a5cd0e@linux.ibm.com> (raw)
In-Reply-To: <20260928051011.GA18753@lst.de>
On 9/28/26 10:40 AM, Christoph Hellwig wrote:
> On Fri, Sep 25, 2026 at 04:51:09PM +0530, Nilay Shroff wrote:
>> Currently, passthru parameters are grouped under struct nvmet_subsys.
>> Since passthru can be configured through configfs and all passthru
>> parameters are exposed under a separate configfs subdirectory, group
>> these parameters under a new struct nvmet_passthru.
>>
>> Grouping passthru-specific parameters in a separate structure makes
>> the code easier to maintain and reason about.
>>
>> There are no functional changes intended.
>
> If the fields are move out anyway, should they be a separate, dynamically
> allocated object so that non-passthrough users don't pay for the memory
> allocation?
>
Yes makes sense. I'll change it to the dynamically allocated object in next
revision.
Thanks,
--Nilay
next prev parent reply other threads:[~2026-09-28 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 11:21 [PATCH 0/2] nvmet: passthru cleanup and fixup I/O hotpath Nilay Shroff
2026-09-25 11:21 ` [PATCH 1/2] nvmet: introduce struct nvmet_passthru Nilay Shroff
2026-09-28 5:10 ` Christoph Hellwig
2026-09-28 6:35 ` Nilay Shroff [this message]
2026-09-25 11:21 ` [PATCH 2/2] nvmet: fix use-after-free error in passthru I/O hotpath Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d763307-ebd4-4d30-8a69-04f418a5cd0e@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=chaitanyak@nvidia.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox