From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12A04EE57D0 for ; Fri, 8 Sep 2023 06:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CxtGgeCI2XmJq+6uhOvPYw8KuX0iEZhv0646A0+eifI=; b=ddGNs9FDhBTpQNYXT0XgAnp+G4 K2R7khm5+Ysb5BTOXFBoe6C+dksWIMGQm9gCQSwiejc5Y7EYVuH7HOncH+Mg6J7YVwdpNYudb7ufu 6XbzSs7vUfLEaVWq6hnKJqFhQ1SzmwIa3I+Y0neTIBIN/F28EJltLdSjpxdfQ0980rTrQCxZk9zAA IRtIZP+S810mu4bLMLOOC6A9cY5omBOPu/AYuDLmzxs5nVUcI1rOUOB9LAWZI5PLABnzCJp8triCd ILeA/jMmmlBMAyQjXuW1qs7OvIZNENqn4SM5kNC+grLkcPfmrzgxxyPlU382ovFPa2kize6uUF2uc J32DyJuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qeUi2-00D8bb-08; Fri, 08 Sep 2023 06:11:14 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qeUhy-00D8aS-2x for linux-nvme@lists.infradead.org; Fri, 08 Sep 2023 06:11:12 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A5672218EE; Fri, 8 Sep 2023 06:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694153469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CxtGgeCI2XmJq+6uhOvPYw8KuX0iEZhv0646A0+eifI=; b=opQEIfC83i2wcgbt16HIXvt47F5wmUlXEhVo82kSwfiHm8cHrdNU7xQwYsZDHsQDOiSx9A 2UDFUQsC8sWBwmD3w3YK2hTKnWiDhHDW9jjIka/nInlr6F0w8VP1roojv2T6ek4Juu/ehg BK3Pu8hXvjEuPmma5MzGQPBwvZBhHsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694153469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CxtGgeCI2XmJq+6uhOvPYw8KuX0iEZhv0646A0+eifI=; b=axkhXS8d1Lqav0ruVLS2Xy5XMJKSwzUXyWdUmiAbfEEC/WaX7Wc5EWl5yVfdxbxYuAD92D hHejxJLV0p4RtcCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 35602131FD; Fri, 8 Sep 2023 06:11:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iNHICv26+mQYaQAAMHmgww (envelope-from ); Fri, 08 Sep 2023 06:11:09 +0000 Message-ID: <5e0271d9-d3a3-45cf-8ba7-fd4617fb6557@suse.de> Date: Fri, 8 Sep 2023 08:11:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 08/12] nvmet: add copy command support for bdev and file ns Content-Language: en-US To: Nitesh Shetty , Jens Axboe , Jonathan Corbet , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Alexander Viro , Christian Brauner Cc: martin.petersen@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com, Anuj Gupta , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org References: <20230906163844.18754-1-nj.shetty@samsung.com> <20230906163844.18754-9-nj.shetty@samsung.com> From: Hannes Reinecke In-Reply-To: <20230906163844.18754-9-nj.shetty@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230907_231111_096357_6DDDA441 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 9/6/23 18:38, Nitesh Shetty wrote: > Add support for handling nvme_cmd_copy command on target. > > For bdev-ns if backing device supports copy offload we call device copy > offload (blkdev_copy_offload). > In case of partial completion from above or absence of device copy offload > capability, we fallback to copy emulation (blkdev_copy_emulation) > > For file-ns we call vfs_copy_file_range to service our request. > > Currently target always shows copy capability by setting > NVME_CTRL_ONCS_COPY in controller ONCS. > > loop target has copy support, which can be used to test copy offload. > trace event support for nvme_cmd_copy. > > Signed-off-by: Nitesh Shetty > Signed-off-by: Anuj Gupta > --- > drivers/nvme/target/admin-cmd.c | 9 ++- > drivers/nvme/target/io-cmd-bdev.c | 97 +++++++++++++++++++++++++++++++ > drivers/nvme/target/io-cmd-file.c | 50 ++++++++++++++++ > drivers/nvme/target/nvmet.h | 4 ++ > drivers/nvme/target/trace.c | 19 ++++++ > 5 files changed, 177 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman