From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FCFAE7719B for ; Tue, 7 Jan 2025 18:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WV+TLZuDtrq0vN0L2SGNhb5nPcib4hM5tam8yfuu2ms=; b=W9SWeb1lU2RlCXfbLcJYyh85Ao scug1Hplwd3Ja74A4nKYdaFlN0EBZrLRMJkVTYH+3/c6yR+cAmnrMlQdq1UfNnNTjgTfjlmkaIUqw n3iQ7CYFO+BYmZMKoeFds0f5dVqWwfBLIxTpyRU8Dcyef6AhA+vykWQrboAffqx2hQE0Btsx+edyl 4FfEWrb8YHInPWpn2ZsmkwJQ/XuSVFZZU1HICd4tqCbs514UT/+YcW5yv6kJsiSqVdQh7Q627RxpU IxG5jZD4DsktTnTLWGGHdRnkuZaDIh/Ru7uNs1Hd74z4Ut0G/2VreBAAZReMs//rTteafUeIkDJFP cGMldCkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVE0z-00000005yGJ-0FBa; Tue, 07 Jan 2025 18:09:17 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tVDs3-00000005wSv-1UFq for linux-nvme@lists.infradead.org; Tue, 07 Jan 2025 18:00:04 +0000 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 507HHR9v017910; Tue, 7 Jan 2025 18:00:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=WV+TLZ uDtrq0vN0L2SGNhb5nPcib4hM5tam8yfuu2ms=; b=fCAySHRaqtq5fm5STvmk9q Lhs0czlU8stIqTWMs5CAVNZP6fwD1RMzrw/gpEC58ljZLGBvWSVqFumg7nBbYCOk MzLu4BwhrJm2KJgdANu2Xqg4s8Nb1FEJQ+mLJiP1TIwQXqSh4B5mZo5n4rfG+4GG o9gieyscm5rwgG+O9oBSUPiks2rsOACizCiqUYpzGG+pDvhKSORIKZ+J4WNZJQgJ E9SZsuEs0omj0ehqcNt1Bs15NLPt/gwc0keiNvDSFks5evXkws51oLgnHvmlxy6D MfwFs5ZrRfwxw7s9ntQJ/A0s3CZkZx+L2rYTjt+P+Udc8mX07+2FlsidHtroGjBA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4410f3ap5q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 17:59:59 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 507GdP97013645; Tue, 7 Jan 2025 17:59:59 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43yganuqj5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 17:59:59 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 507HxwOh38470348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2025 17:59:58 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9591E58056; Tue, 7 Jan 2025 17:59:58 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB04C58052; Tue, 7 Jan 2025 17:59:52 +0000 (GMT) Received: from [9.171.94.59] (unknown [9.171.94.59]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Jan 2025 17:59:51 +0000 (GMT) Message-ID: <60ac457f-d762-414b-9b3a-b85a2181c2ce@linux.ibm.com> Date: Tue, 7 Jan 2025 23:29:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] block: fix queue freeze vs limits lock order in sysfs store methods To: Christoph Hellwig , Jens Axboe Cc: Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20250107063120.1011593-1-hch@lst.de> <20250107063120.1011593-6-hch@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20250107063120.1011593-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SAmk3EbAribcnbNq4fhQEPQvwJ5g5bbV X-Proofpoint-ORIG-GUID: SAmk3EbAribcnbNq4fhQEPQvwJ5g5bbV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=531 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501070149 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250107_100003_500562_B3626AD0 X-CRM114-Status: UNSURE ( 8.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Looks good to me. Reviewed-by: Nilay Shroff