From: John Garry <john.g.garry@oracle.com>
To: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: ahuang12@lenovo.com, axboe@kernel.dk,
damien.lemoal@opensource.wdc.com, hch@lst.de,
iommu@lists.linux.dev, ionut_n2001@yahoo.com, kbusch@kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, m.szyprowski@samsung.com,
robin.murphy@arm.com, sagi@grimberg.me, stable@vger.kernel.org,
sunlightlinux@gmail.com
Subject: Re: [PATCH v2 0/1] scsi: sas: fix mkfs.xfs failure due to bogus optimal_io_size
Date: Wed, 18 Mar 2026 08:51:38 +0000 [thread overview]
Message-ID: <60c133d2-e9f1-4b5f-b3c4-4c37dd62dbb7@oracle.com> (raw)
In-Reply-To: <20260318074314.17372-1-ionut.nechita@windriver.com>
On 18/03/2026 07:43, Ionut Nechita (Wind River) wrote:
> Answer to John's question about blk_validate_limits() rounding:
> blk_validate_limits() rounds optimal_io_size down to physical_block_size
> (4096), but does NOT enforce that optimal_io_size is a multiple of
> minimum_io_size (8192). So optimal_io_size=16773120 survives validation
> unchanged — it is already a multiple of 4096. The mismatch only shows
> up when mkfs.xfs divides optimal_io_size by minimum_io_size and expects
> an integer result: 16773120 / 8192 = 2047.5, giving swidth=4095 and
> sunit=2, with 4095 % 2 != 0.
thanks for the info. I feel that that io_opt should be a multiple of the
io_min and we should enforce it in blk queue limits validation, but that
can mask problems like you have seen.
prev parent reply other threads:[~2026-03-18 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 7:43 [PATCH v2 0/1] scsi: sas: fix mkfs.xfs failure due to bogus optimal_io_size Ionut Nechita (Wind River)
2026-03-18 7:43 ` [PATCH 1/1] scsi: sas: skip opt_sectors when DMA reports no real optimization hint Ionut Nechita (Wind River)
2026-03-18 7:53 ` Christoph Hellwig
2026-03-18 16:39 ` Robin Murphy
2026-03-18 8:51 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60c133d2-e9f1-4b5f-b3c4-4c37dd62dbb7@oracle.com \
--to=john.g.garry@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahuang12@lenovo.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=ionut.nechita@windriver.com \
--cc=ionut_n2001@yahoo.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=sunlightlinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox