From: Damien Le Moal <dlemoal@kernel.org>
To: Guixin Liu <kanie@linux.alibaba.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: fix NULL pointer dereference in nvmet_execute_identify_ns_zns()
Date: Tue, 4 Aug 2026 13:29:54 +0900 [thread overview]
Message-ID: <617efddf-bf71-477d-bdf7-a05f60b41336@kernel.org> (raw)
In-Reply-To: <20260804033605.3973127-1-kanie@linux.alibaba.com>
On 8/4/26 12:36, Guixin Liu wrote:
> When a host issues an Identify command with CNS 05h (I/O Command Set
> specific Identify Namespace) and CSI 02h (ZNS) targeting a file-backed
> namespace, nvmet_execute_identify_ns_zns() calls bdev_is_zoned() on
> req->ns->bdev. A file-backed namespace has no block device, so
> req->ns->bdev is NULL and bdev_is_zoned() dereferences it, oopsing.
>
> The I/O command set is selected by the host-supplied CSI field and the
> command is routed here whenever CONFIG_BLK_DEV_ZONED is enabled,
> independent of the namespace backing type, so any file-backed namespace
> is exposed.
>
> Reject the command with Invalid Field when the namespace is not backed
> by a block device.
>
> Fixes: aaf2e048af27 ("nvmet: add ZBD over ZNS backend support")
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Looks good to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-08-04 4:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 3:36 [PATCH] nvmet: fix NULL pointer dereference in nvmet_execute_identify_ns_zns() Guixin Liu
2026-08-04 4:29 ` Damien Le Moal [this message]
2026-08-04 16:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=617efddf-bf71-477d-bdf7-a05f60b41336@kernel.org \
--to=dlemoal@kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox