From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90478C369D3 for ; Mon, 28 Apr 2025 07:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R23FCT6upMUICY5e5yi7gKI289TI9HBN4syIytuQ13A=; b=3Gwy6gdhY/+ijaghS1SkJQjYux gW5SZSy/PcVYCiHruzxFcXo2BX9YZX0r6xG+lJe21JaUKlPZlkIzg9qKxbUBdtmr13WcSlvveRDbw 7y9vHfszL3IBy7oBiHJ12vJVcL459WOboBN56jalPGKpxYQCFttzkxgB12gmI3IjVia/6sYIacaRy TTy1KgUk1h65KFAdQZ4VLx6pw0iDUuhyDBUnuunkgCxLz9SVY522IcFZV09naFLLHKkCXWadeHRGs Sdh4ddvHkp9ECIBd1uaaPyp0ZrYcb3GAEkg2mR4+MODzH8WxmGf1mNPVWHHP0Ee9XHEnPPun/PKQ6 4PH31CFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9JJI-00000005KEr-4Bc6; Mon, 28 Apr 2025 07:53:53 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9J64-00000005HA3-3kIB for linux-nvme@lists.infradead.org; Mon, 28 Apr 2025 07:40:15 +0000 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53RLtMRP008942; Mon, 28 Apr 2025 07:40:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=R23FCT 6upMUICY5e5yi7gKI289TI9HBN4syIytuQ13A=; b=M/vJawf3e3pg1zlxsm+CbF OXqtI5Q1RgxMEgrJSfi1rSd04KQ91KtWnTdENAcFW+dEM0BwzMPHJAkTmSi7rS5M 0WroUK0GHedOzfH/8gJSqCl1XZ4dGTRUcZAh66r2Y7rvD8Zt3icYCndhTDaX1JNc n0PuasNvwefVrIkGck98mT2TErny3l3I7yR8l/WpIwyq/G2yybCPmaf1q//QaFEL Rs27DnDu/UyvFWmBkL0TxptwDgF4QzlUptSXeOxmi/xuhij//qR4/tH73VkXQpXg dOFovp4yxmZKr1Yv9WSOhRUZ956+YDRu4khlxzad87nhlVSlY2phOOBba1765KWw == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 469v5khw77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 07:40:07 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53S6Itvs031628; Mon, 28 Apr 2025 07:40:06 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4699ttwhs0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 07:40:06 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53S7e55s31261300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Apr 2025 07:40:05 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B800958067; Mon, 28 Apr 2025 07:40:05 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B98805805D; Mon, 28 Apr 2025 07:40:01 +0000 (GMT) Received: from [9.43.89.161] (unknown [9.43.89.161]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 28 Apr 2025 07:40:01 +0000 (GMT) Message-ID: <6305bdd1-97bd-44a5-98f7-a167b7c64c0d@linux.ibm.com> Date: Mon, 28 Apr 2025 13:09:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCHv2 1/3] nvme-multipath: introduce delayed removal of the multipath head node To: Sagi Grimberg , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Cc: hch@lst.de, kbusch@kernel.org, hare@suse.de, jmeneghi@redhat.com, axboe@kernel.dk, martin.petersen@oracle.com, gjoyce@ibm.com References: <20250425103319.1185884-1-nilay@linux.ibm.com> <20250425103319.1185884-2-nilay@linux.ibm.com> <859e8758-83a2-46d2-81ed-c5199f326508@grimberg.me> Content-Language: en-US From: Nilay Shroff In-Reply-To: <859e8758-83a2-46d2-81ed-c5199f326508@grimberg.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tep60Gd0Xl1XIbTP1rYFJzoznczwNCsF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI4MDA2MiBTYWx0ZWRfX6TbtyUJyCY3C mRX/IeTHeF+i7YWDbjrWLNuddrmPvxEB2PrkaES8x5xuPhTCCSNaLCky10Ur1vcwdOQcKbp4S/x E2rahWS3DeE4gJObhsV783rmAfatDHj+nDeS1R02lUZxzoTCxQt4HJecMfJ83gUXlCfT7wjtGuB Ij9jr22Tv+YRftgbUvegElHfR+NwlFcWLKecjkC6hz8FozTZcnkM/y0olZAsX0UZ4IBaDcXaArA bl7vo9KVowVQWeIYVgcIwMlgfkXqpZvPz04Vlskxar2YVXq9CayzOEU7uP8W8TQC4lvwc8luxHq CLnY2b2HTtgKnepTK2L/GegAb76yvhu5vy4lIhNq2SJw+N+Qt2IGWO5GqeJqmBmgwZyRQdgxwF0 iNnmnMxx4vicr9Abi2PalW52/CPXYUcBg5nqK+hP6SB9ZDtq1+TTWYTWKhN4f9QPuHJueMfm X-Proofpoint-GUID: tep60Gd0Xl1XIbTP1rYFJzoznczwNCsF X-Authority-Analysis: v=2.4 cv=DvxW+H/+ c=1 sm=1 tr=0 ts=680f30d7 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=QUCVYTkQBvY6EVLPVrYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-28_02,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxlogscore=830 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504280062 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250428_004012_946052_DCA1E910 X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 4/26/25 3:56 AM, Sagi Grimberg wrote: >>   @@ -3688,6 +3688,8 @@ static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl, >>       ratelimit_state_init(&head->rs_nuse, 5 * HZ, 1); >>       ratelimit_set_flags(&head->rs_nuse, RATELIMIT_MSG_ON_RELEASE); >>       kref_init(&head->ref); >> +    if (ctrl->opts) > > While this check is correct, perhaps checking ctrl->ops->flags & NVME_F_FABRICS > would be clearer. > Sure, I'd update this in the next patch. Thanks, --Nilay