From: Chao Leng <lengchao@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-nvme@lists.infradead.org>, <linux-block@vger.kernel.org>,
<sagi@grimberg.me>, <kbusch@kernel.org>, <axboe@kernel.dk>,
<ming.lei@redhat.com>, <paulmck@kernel.org>
Subject: Re: [PATCH v2 0/2] improve nvme quiesce time for large amount of namespaces
Date: Thu, 20 Oct 2022 17:36:21 +0800 [thread overview]
Message-ID: <6491f977-95f2-e40e-aa8b-d0671b517903@huawei.com> (raw)
In-Reply-To: <20221020063448.GA6246@lst.de>
On 2022/10/20 14:34, Christoph Hellwig wrote:
> I though the conclusion from last round was to move the srcu_struct to
> the tagset?
If move the srcu_struct to the tagset, may loss the flexibility.
I am not sure that it is good for other modules currently using blk_mq_quiesce_queue.
Another, I am not sure if there will be a future scenario where blk_mq_quiesce_queue
will have to be used, and if it is good for such scenario.
It is a acceptable cost to allocate a temporary array for SRCU, the max memory size
is actually a few hundred KB, and most of the time it's less than a few KB.
So I did not move the srcu_struct to the tagset in patch V3.
It sounds like a good idea that explore moving the srcu_struct to the tag_set,
But we may need more time to analysis it.
I suggest that do the optimization in a separate patch set.
>
> .
>
next prev parent reply other threads:[~2022-10-20 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 3:53 [PATCH v2 0/2] improve nvme quiesce time for large amount of namespaces Chao Leng
2022-10-20 3:53 ` [PATCH v3 1/2] blk-mq: add tagset quiesce interface Chao Leng
2022-10-20 16:11 ` Paul E. McKenney
2022-10-20 3:53 ` [PATCH v3 2/2] nvme: use blk_mq_[un]quiesce_tagset Chao Leng
2022-10-20 6:11 ` Sagi Grimberg
2022-10-20 9:47 ` Chao Leng
2022-10-20 6:34 ` [PATCH v2 0/2] improve nvme quiesce time for large amount of namespaces Christoph Hellwig
2022-10-20 9:36 ` Chao Leng [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-13 9:44 Chao Leng
2022-10-13 14:32 ` Chaitanya Kulkarni
2022-10-14 2:12 ` Chao Leng
2022-10-15 0:30 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6491f977-95f2-e40e-aa8b-d0671b517903@huawei.com \
--to=lengchao@huawei.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=paulmck@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox