public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: rasheed.hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Rasheed.Hsueh@lcfuturecenter.com"
	<Rasheed.Hsueh@lcfuturecenter.com>,
	"wuxy23@lenovo.com" <wuxy23@lenovo.com>,
	"gwendal@chromium.org" <gwendal@chromium.org>,
	"rasheed.yh@gmail.com" <rasheed.yh@gmail.com>
Subject: Re: [PATCH v1 1/1] nvme-pci: disable write zeros support on UMIC and Samsung SSDs
Date: Fri, 10 Jun 2022 09:18:23 +0000	[thread overview]
Message-ID: <64e6741b-b9e7-51a6-7f72-fa5fd75a844c@nvidia.com> (raw)
In-Reply-To: <20220610062734.9927-2-rasheed.hsueh@lcfc.corp-partner.google.com>

On 6/9/22 23:27, rasheed.hsueh wrote:
> Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
> Write Zeroes command"), UMIS and Samsung has the same issue:
> [ 6305.633887] blk_update_request: operation not supported error,
> dev nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0
> phys_seg 0 prio class 0
> 
> So also disable Write Zeroes command on UMIS and Samsung.
> 
> Signed-off-by: rasheed.hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



  reply	other threads:[~2022-06-10  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  6:27 [PATCH v1 0/1] nvme-pci: disable write zeros support on UMIC and Samsung SSDs rasheed.hsueh
2022-06-10  6:27 ` [PATCH v1 1/1] " rasheed.hsueh
2022-06-10  9:18   ` Chaitanya Kulkarni [this message]
2022-06-13 17:58   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64e6741b-b9e7-51a6-7f72-fa5fd75a844c@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=Rasheed.Hsueh@lcfuturecenter.com \
    --cc=axboe@fb.com \
    --cc=gwendal@chromium.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=rasheed.hsueh@lcfc.corp-partner.google.com \
    --cc=rasheed.yh@gmail.com \
    --cc=sagi@grimberg.me \
    --cc=wuxy23@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox