From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH] nvmet: nvmet.h configfs helper cleanup
Date: Tue, 13 Feb 2024 07:43:37 +0000 [thread overview]
Message-ID: <655bf625-c998-4bac-a126-7d25b61f454a@nvidia.com> (raw)
In-Reply-To: <20240212065919.GB17561@lst.de>
On 2/11/24 22:59, Christoph Hellwig wrote:
> On Sun, Feb 11, 2024 at 03:39:49PM -0800, Chaitanya Kulkarni wrote:
>> Functions to_nvmet_ns(), to_ana_group(), to_subsys(), to_host() and
>> namespaces_to_subsys() are only used in target/configfs.c, move it
>> to the appropriate file instead of bloating common header.
> Does it matter? I find having the helpers to do a container_of right
> next to the structures they are used on pretty helpful.
>
hmmm, from what I know it is a bad practice to carry private interface
in header file vs prioritizing the readability, please disregard this
patch if it is going to create any inconvenience.
-ck
prev parent reply other threads:[~2024-02-13 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 23:39 [PATCH] nvmet: nvmet.h configfs helper cleanup Chaitanya Kulkarni
2024-02-12 6:59 ` Christoph Hellwig
2024-02-13 7:43 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655bf625-c998-4bac-a126-7d25b61f454a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox