Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Asleson <tasleson@redhat.com>
To: linux-nvme@lists.infradead.org
Subject: Re: nvmet: Kernel oops when doing mkfs on nvme-tcp device
Date: Mon, 23 Mar 2020 18:37:36 -0500	[thread overview]
Message-ID: <66a7c3e3-66a1-8a97-92ed-31ad00d6eb89@redhat.com> (raw)
In-Reply-To: <ad18c611-33bd-3dd8-989a-0e4b950db20c@grimberg.me>

On 3/23/20 5:02 PM, Sagi Grimberg wrote:
> Tony, does this patch work for you? It makes the issue disappear
> on my end.

I built a generic 5.5 kernel and modules with debug.  I recreated the
issue and using gdb I get:

...
Reading symbols from
/lib/modules/5.5.0/kernel/drivers/nvme/host/nvme-tcp.ko...
(gdb) l nvme_tcp_io_work+0x303
Function "nvme_tcp_io_work+0x303" not defined.
(gdb) l *(nvme_tcp_io_work+0x303)
0x1c03 is in nvme_tcp_io_work (drivers/nvme/host/tcp.c:181).

179  static inline struct page *nvme_tcp_req_cur_page(struct
nvme_tcp_request *req)
 180 {
 181         return req->iter.bvec->bv_page;
 182 }

which matches what Chaitanya found.

After applying your patch I'm no longer hitting this issue!

Thanks everyone!

-Tony


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2020-03-23 23:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 21:36 nvmet: Kernel oops when doing mkfs on nvme-tcp device Tony Asleson
2020-03-20 22:23 ` Chaitanya Kulkarni
2020-03-20 23:24   ` Tony Asleson
2020-03-20 22:54 ` Sagi Grimberg
2020-03-20 22:59   ` Sagi Grimberg
2020-03-20 23:46     ` Tony Asleson
2020-03-21  0:43       ` Chaitanya Kulkarni
2020-03-23 17:56         ` Tony Asleson
2020-03-23 19:42           ` Sagi Grimberg
2020-03-23 20:10             ` Tony Asleson
2020-03-20 23:43   ` Tony Asleson
2020-03-23  8:33     ` Sagi Grimberg
2020-03-23 15:57       ` Tony Asleson
2020-03-23 19:41         ` Sagi Grimberg
2020-03-23 20:46           ` Chaitanya Kulkarni
2020-03-23 20:52             ` Sagi Grimberg
2020-03-23 22:02               ` Sagi Grimberg
2020-03-23 23:37                 ` Tony Asleson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66a7c3e3-66a1-8a97-92ed-31ad00d6eb89@redhat.com \
    --to=tasleson@redhat.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox