From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53CEFC7EE22 for ; Fri, 28 Apr 2023 17:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mx+u+e8F3tpe9jME3ZkNhf/uGT2LdeSIrgmUdMOCoHA=; b=FaCj0LALD6KoA6LnRP/oK79FuZ KRoX1wT7+ftYQ8fUxoHTb40ZXVyEMs5evk0GY1x8xIvn2P1xy1Q6fbxduAjP40jWYJ+F39I+o9c1k tl7lKTQ3AVpVkv9jm1qx80vnssPwyyQrCPvRz7EHP1hwcHhrmXa99+x0gr5EdUtBgSQ/0aq4PZwJB +y+DxGbjn2Fm+KaRJtIsL6fw68IXfCdRTg6clfljCE+TSUX4zcH+BRoAVSTxNCGwMI55ss+ImUqNi wt1uvJZBwKJ0siyWM4iRcTKhEXFvdjppDfv2ErmcyTbKB6+QrJFNAQtp2mONHULlxT1yOpANtfh5Y U+LqMQrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1psRtM-00BLF6-0C; Fri, 28 Apr 2023 17:28:20 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1psRtJ-00BLDq-32 for linux-nvme@lists.infradead.org; Fri, 28 Apr 2023 17:28:19 +0000 Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-32b625939d4so3845645ab.1 for ; Fri, 28 Apr 2023 10:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1682702896; x=1685294896; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mx+u+e8F3tpe9jME3ZkNhf/uGT2LdeSIrgmUdMOCoHA=; b=StkHpsTFpc04mYRpir23kIUT3IfSMOjigxosKHgX+gCeWel7dyhRfqGvXbHUZwOaj5 cOmpDi3mLtJz1AcA9iR3BmwiuJ2G29nre1arFQstFKx8fo7wCREJHYvPPagMXM5Pv67v CGQc9H89+myfRH8sV3i5udBtHw1LMoZj4bEJmm6XkLju7wGfcsTSRbQ25G/Yrxq8HNdo 9k8pTj0NfwdNMyUF7oBvrqgu8uj5CNNJZ0sAJn+Y3KlOC8s4abk9wsZHUojThtZnGUao 1BI5+xbPnnEDtyZ+OziPsSMtxIFr83qa5KTVmeR23CRHek3oKvSC5oJq2elYhPFhVF5j Uxjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682702896; x=1685294896; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mx+u+e8F3tpe9jME3ZkNhf/uGT2LdeSIrgmUdMOCoHA=; b=HCC5MLzt/LVD8iNJ+QOpTh2L78OuDM1aLH0DUUINSw41WfjZA5eBUMH8JG2q4nD0T/ rn79sQ7gXH6KU4DGkw+WH19HdyukZP9gnAtuEZS1nGBzz663q5F4+Yal+0IfJyCwRNcZ gi+/X8UaKpO/8/OdQRyWeyfoKNKUg6hBbMDlA+tbTfgjImRNYT39N8VGAyuNeh0RE1xO uwLmT1TIoY38c+6WlMSAktPFwek2PvEgu9E4K+ZkU0NC5Sj6mk2ce2vSJ5VrwhbSlLXs 4gWLi+Jy0WJ0AZdBE6lNLgkYVSDrORO0/bHt6EkQusWAica9qMVbtNuPaHv9COnT5rvb Wkjg== X-Gm-Message-State: AC+VfDxBGPy7hcufL2h9fqDhOK4IbpFleX0wZerqBjgA1njYdPJ1FhqR oFTnitdnQfaNYbXy7TDfxDSt9w== X-Google-Smtp-Source: ACHHUZ6VVhmsMluENvVdOeusjeeWlsYRSHQORwLpr/F9aC6roaNxN8srB7J+NWD6SEU5RENT5xw02Q== X-Received: by 2002:a05:6602:1696:b0:760:dfd3:208d with SMTP id s22-20020a056602169600b00760dfd3208dmr4267661iow.0.1682702896169; Fri, 28 Apr 2023 10:28:16 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id d123-20020a026281000000b00405f36ed05asm6225655jac.55.2023.04.28.10.28.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 10:28:15 -0700 (PDT) Message-ID: <678232fa-fd02-37b7-3048-a124c4ffdc71@kernel.dk> Date: Fri, 28 Apr 2023 11:28:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 0/3] io_uring: Pass the whole sqe to commands Content-Language: en-US To: Breno Leitao , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, asml.silence@gmail.com Cc: leit@fb.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, ming.lei@redhat.com References: <20230421114440.3343473-1-leitao@debian.org> From: Jens Axboe In-Reply-To: <20230421114440.3343473-1-leitao@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230428_102817_978190_037B1FBE X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 4/21/23 5:44?AM, Breno Leitao wrote: > These three patches prepare for the sock support in the io_uring cmd, as > described in the following RFC: > > https://lore.kernel.org/lkml/20230406144330.1932798-1-leitao@debian.org/ > > Since the support linked above depends on other refactors, such as the sock > ioctl() sock refactor[1], I would like to start integrating patches that have > consensus and can bring value right now. This will also reduce the patchset > size later. > > Regarding to these three patches, they are simple changes that turn > io_uring cmd subsystem more flexible (by passing the whole SQE to the > command), and cleaning up an unnecessary compile check. > > These patches were tested by creating a file system and mounting an NVME disk > using ubdsrv/ublkb0. Looks mostly good to me, do agree with Christoph's comments on the two patches. Can you spin a v3? Would be annoying to miss 6.4 with this, as other things will be built on top of it. -- Jens Axboe