From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F53C48260 for ; Tue, 6 Feb 2024 03:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PMJ17O1CmqNUVr9CqnSAoYW18iVFOklGqfFbXcdL5RQ=; b=NXpDg9Og09NNxQ0LYnvQwpeNs9 ztUflcqQcC0AGMqZKsKqCYoq6/UQS4Bc583DUF2Yyi+5gO78A6wNa8+j7ytQnwpB/Q4JQ2Dwh2Y/p wkU60Ed1QxzeEV4BpFSv8ruBXXJSx2sBXx+8FVisQqbmzjen65kzyaMone1voelFe1uRgSLTWm0xe WEKE33Dg7fP1oR8Qj7wDUaW/8TxM8WJM1imYLM4iOrTSnj3O9r6ksnVn3grQRvNWd4jKN23OJuDO5 gIf8d5O8nWoj1IxGO9u2fSI320uxGZki5Lw9ei9z3189e+p6bnLkKWP6ZVT6EFV7O36K4i7B212al L69PB2Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXBkt-00000005s8K-1QLR; Tue, 06 Feb 2024 03:04:15 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXBkp-00000005s7M-2aju for linux-nvme@lists.infradead.org; Tue, 06 Feb 2024 03:04:14 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 80E37221A0; Tue, 6 Feb 2024 03:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707188648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PMJ17O1CmqNUVr9CqnSAoYW18iVFOklGqfFbXcdL5RQ=; b=aRu7T3pQG6tTCRTJTiS1mIQsc8jAB5BLHZuqWknkOAoBJsDjEm/msx5XEAKgOMyoxpTYde b7gua5F7B3Rd1c796/UmIHGif7MR3NzUmXen200XdpvdcY9Keg/T7xXx31GrppifP9WgNt /bzte79pyZzQ6bUUE9SJWHaDVx0CVbk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707188648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PMJ17O1CmqNUVr9CqnSAoYW18iVFOklGqfFbXcdL5RQ=; b=8rrEetDgjr9nA6tQE19WnulbyHkTuwtID7tiyqiWfecIztXvF6vTDQNqDqhVkajdDUNace M51pM2PYDm3ILPBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707188648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PMJ17O1CmqNUVr9CqnSAoYW18iVFOklGqfFbXcdL5RQ=; b=aRu7T3pQG6tTCRTJTiS1mIQsc8jAB5BLHZuqWknkOAoBJsDjEm/msx5XEAKgOMyoxpTYde b7gua5F7B3Rd1c796/UmIHGif7MR3NzUmXen200XdpvdcY9Keg/T7xXx31GrppifP9WgNt /bzte79pyZzQ6bUUE9SJWHaDVx0CVbk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707188648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PMJ17O1CmqNUVr9CqnSAoYW18iVFOklGqfFbXcdL5RQ=; b=8rrEetDgjr9nA6tQE19WnulbyHkTuwtID7tiyqiWfecIztXvF6vTDQNqDqhVkajdDUNace M51pM2PYDm3ILPBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3B851132DD; Tue, 6 Feb 2024 03:04:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id USo/OKWhwWW4GgAAD6G6ig (envelope-from ); Tue, 06 Feb 2024 03:04:05 +0000 Message-ID: <68049531-3114-4afc-b6ba-e226b14b7806@suse.de> Date: Tue, 6 Feb 2024 12:03:59 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/12] nvmet-fc: avoid deadlock on delete association path Content-Language: en-US To: Daniel Wagner , James Smart Cc: Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240131085112.21668-1-dwagner@suse.de> <20240131085112.21668-11-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20240131085112.21668-11-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aRu7T3pQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8rrEetDg X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.48 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.98)[99.91%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 80E37221A0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_190411_829300_F5818922 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/31/24 16:51, Daniel Wagner wrote: > When deleting an association the shutdown path is deadlocking because we > try to flush the nvmet_wq nested. Avoid this by deadlock by deferring > the put work into its own work item. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Daniel Wagner > --- > drivers/nvme/target/fc.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich