Re: [PATCH V5 0/1] nvme: allow passthru cmd error logging

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 5/5/23 14:59, alan.adamson@oracle.com wrote:
>
>>>>> In nvme_end_req()_ we only log errors which are for non-passthru
>>>>> commands. Add a helper function nvme_log_err_passthru() which 
>>>>> allows us
>>>>> to log error for passthru commands by decoding cdw10-cdw15 values of
>>>>> nvme command.
>>>> CK,
>>>>
>>>> Thanks for doing this. Looks good.  I've tested it in my environment.
>>>>
>>>> Alan
>>>>
>>>>
>>> Thanks for having a look, let's wait for others to have comments.
>>>
>>> -ck
>>
>> I'll be on vacation next week so we will move forward with the patch 
>> when I get back on 4/24.
>
> I'm back from vacation.  We can continue with the review.
>
>
> Thanks,
>
> Alan
>

since you've tested V5 in your environment, I think we can pick this up 
before
next PR if there is no major objection ...

-ck