Re: nvme in-band authentication blktests - nvme/043

[Hannes Reinecke <hare@suse.de>]

On 7/3/23 08:46, Shinichiro Kawasaki wrote:
> CC+: Hannes,
> 
> On Jun 29, 2023 / 12:24, alan.adamson@oracle.com wrote:
>> I'm playing around with in-band authentication and using blktests to see how
>> to setup it up and use it.  In test nvme/043, a valid hostkey is never
>> initialized and a NULL is being used to setup the target and to connect.  Is
>> this expected?  The test with the NULL hostkey passes.  I updated the test
>> to use a valid key and it also passes.
>>
>>
>> diff --git a/tests/nvme/043 b/tests/nvme/043
>> index a030884..d5e0d4b 100755
>> --- a/tests/nvme/043
>> +++ b/tests/nvme/043
>> @@ -40,6 +40,8 @@ test() {
>>          fi
>>          hostnqn="nqn.2014-08.org.nvmexpress:uuid:${hostid}"
>>
>> +       hostkey="$(nvme gen-dhchap-key -n ${subsys_name} 2> /dev/null)"
>> +
>>          _setup_nvmet
>>
>>          truncate -s "${nvme_img_size}" "${file_path}"
>>
> 
> Alan's question looks valid for me.
> 
> Hannes, may I ask your comment?

Yeah, that's correct.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes